-
Couldn't load subscription status.
- Fork 1.3k
[Reader] Update follow tags logic in "Manage Tags & Blogs" screen #20171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader] Update follow tags logic in "Manage Tags & Blogs" screen #20171
Conversation
… the tag in the list when unsubscribed, and only change the follow button status
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20171-a02167a | |
| Commit | a02167a | |
| Direct Download | jetpack-prototype-build-pr20171-a02167a.apk |
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20171-a02167a | |
| Commit | a02167a | |
| Direct Download | wordpress-prototype-build-pr20171-a02167a.apk |
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, though I found a blocking bug, since it looks like the button change is only visual, but is not adding back the tag/keeping it when the user taps Subscribe again.
Besides that I also added some minor suggestions.
WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderTagAdapter.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderTagAdapter.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderTagAdapter.java
Outdated
Show resolved
Hide resolved
Generated by 🚫 dangerJS |
|
Thanks for the review, @thomashorta ! The bug should be fixed and I've applied your suggestions 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it again after the changes and everything looks good to me now!


Fixes #19353
To Test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
--
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist: