[Gutenberg] - Add support for unselecting blocks with the hardware back button #19828

geriux · 2023-12-20T19:50:18Z

Related PRs:

[Mobile] Unselect blocks using the hardware back button (Android) gutenberg-mobile#6483
[Mobile] Unselect blocks using the hardware back button (Android) WordPress/gutenberg#57279

This PR adds the functionality to be able to intercept the hardware back button from the React Native app.

It adds a OnBackPressedCallback in GutenbergContainerFragment to be able to manage the back button events from the React Native's BackHandler API.

If the Gutenberg editor adds a new back button subscription it will first handle that and then it will bubble up the event attached in the EditPostActivity

To Test:

Follow the test case scenarios in the Gutenberg PR description.

Regression Notes

Potential unintended areas of impact
- It should only affect the editor.
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manual testing and existing UI tests.
What automated tests I added (or what prevented me from doing so)
- TODO

PR Submission Checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
Talkback.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
Large and small screen sizes. (Tablet and smaller phones)
Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

…ct Native

wpmobilebot · 2023-12-20T20:08:41Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19828-56c03b3
	Commit	`56c03b3`
	Direct Download	`wordpress-prototype-build-pr19828-56c03b3.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-12-20T20:10:45Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19828-56c03b3
	Commit	`56c03b3`
	Direct Download	`jetpack-prototype-build-pr19828-56c03b3.apk`

Note: Google Login is not supported on these builds.

.../editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergContainerFragment.java

WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java

…c or if it should just bubble up the events

fluiddot

Approved via WordPress/gutenberg#57279 (review).

fluiddot · 2024-01-02T11:04:57Z

RELEASE-NOTES.txt

@@ -5,6 +5,7 @@
 * [*] Filter media types when sharing files to the editor [https://github.com/wordpress-mobile/WordPress-Android/pull/19754]
 * [***] [Jetpack-only] Plans: Upgrade to a Plan from domains dashboard in Jetpack app [https://github.com/wordpress-mobile/WordPress-Android/pull/19818]
 * [**] [internal] Removes unused resources and code [https://github.com/wordpress-mobile/WordPress-Android/pull/19788]
+* [*] Add support for unselecting blocks with the hardware back button [https://github.com/wordpress-mobile/WordPress-Android/pull/19828]


Nitpick: I'd add the prefix Block Editor: to highlight that this is a change related to the editor.

wpmobilebot · 2024-01-02T18:38:12Z

Found 1 violations:

The PR caused the following dependency changes:

 \--- project :libs:editor
-     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.110.0-alpha2
-          +--- com.facebook.fresco:animated-gif:2.0.0
-          |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
-          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |    \--- com.facebook.fresco:animated-base:2.0.0
-          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
-          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         +--- com.facebook.fresco:animated-drawable:2.0.0
-          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
-          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         \--- com.parse.bolts:bolts-tasks:1.4.0
-          +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
-          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-6
-          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
-          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    |    \--- com.google.guava:guava:27.1-android
-          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
-          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
-          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-          |    |         \--- androidx.media:media:1.2.1 (*)
-          |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
-          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
-          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.11.0 (*)
-          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.11.0 (*)
-          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-4
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-get-random-values:1.4.0
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-safe-area-context:4.6.3
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.10 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-screens:3.22.0
-          |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.9.10 (*)
-          |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
-          |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
-          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
-          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-          |    +--- com.google.android.material:material:1.1.0 -> 1.9.0 (*)
-          |    \--- androidx.core:core-ktx:1.5.0 -> 1.10.0 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-svg:13.9.0
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-webview:11.26.1
-          |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.10 (*)
-          |    \--- androidx.webkit:webkit:1.4.0 -> 1.7.0 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-masked-view:0.2.9
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-clipboard:1.11.2
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-fast-image:8.5.11
-          |    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1
-          |    |    +--- com.github.bumptech.glide:gifdecoder:4.15.1
-          |    |    |    \--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
-          |    |    +--- com.github.bumptech.glide:disklrucache:4.15.1
-          |    |    +--- com.github.bumptech.glide:annotations:4.15.1
-          |    |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
-          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
-          |    |    +--- androidx.exifinterface:exifinterface:1.3.3 -> 1.3.6 (*)
-          |    |    \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
-          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
-          |         +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1 (*)
-          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.11.0 (*)
-          |         \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-gesture-handler:2.10.2
-          |    +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
-          |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
-          |    +--- androidx.core:core-ktx:1.6.0 -> 1.10.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.9.10 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-linear-gradient:2.7.3
-          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.110.0-alpha2
-          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-          |    +--- androidx.gridlayout:gridlayout:1.0.0
-          |    |    +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
-          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
-          |    +--- androidx.cardview:cardview:1.0.0 (*)
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
-          |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-          |    +--- org.wordpress:aztec:v1.9.0 (*)
-          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.9.0 (*)
-          |    +--- org.wordpress.aztec:wordpress-comments:v1.9.0 (*)
-          |    +--- org.wordpress.aztec:glide-loader:v1.9.0
-          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-          |    |    +--- org.wordpress:aztec:v1.9.0 (*)
-          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.110.0-alpha3
+          +--- com.facebook.fresco:animated-gif:2.0.0
+          |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
+          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |    \--- com.facebook.fresco:animated-base:2.0.0
+          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
+          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         +--- com.facebook.fresco:animated-drawable:2.0.0
+          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
+          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         \--- com.parse.bolts:bolts-tasks:1.4.0
+          +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
+          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-6
+          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    |    \--- com.google.guava:guava:27.1-android
+          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
+          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+          |    |         \--- androidx.media:media:1.2.1 (*)
+          |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
+          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.11.0 (*)
+          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.11.0 (*)
+          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-4
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-get-random-values:1.4.0
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-safe-area-context:4.6.3
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.10 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-screens:3.22.0
+          |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.9.10 (*)
+          |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
+          |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
+          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+          |    +--- com.google.android.material:material:1.1.0 -> 1.9.0 (*)
+          |    \--- androidx.core:core-ktx:1.5.0 -> 1.10.0 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-svg:13.9.0
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-webview:11.26.1
+          |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.10 (*)
+          |    \--- androidx.webkit:webkit:1.4.0 -> 1.7.0 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-masked-view:0.2.9
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-clipboard:1.11.2
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-fast-image:8.5.11
+          |    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1
+          |    |    +--- com.github.bumptech.glide:gifdecoder:4.15.1
+          |    |    |    \--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
+          |    |    +--- com.github.bumptech.glide:disklrucache:4.15.1
+          |    |    +--- com.github.bumptech.glide:annotations:4.15.1
+          |    |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
+          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
+          |    |    +--- androidx.exifinterface:exifinterface:1.3.3 -> 1.3.6 (*)
+          |    |    \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
+          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+          |         +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1 (*)
+          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.11.0 (*)
+          |         \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-gesture-handler:2.10.2
+          |    +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
+          |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
+          |    +--- androidx.core:core-ktx:1.6.0 -> 1.10.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.9.10 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-linear-gradient:2.7.3
+          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.110.0-alpha3
+          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+          |    +--- androidx.gridlayout:gridlayout:1.0.0
+          |    |    +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
+          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+          |    +--- androidx.cardview:cardview:1.0.0 (*)
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
+          |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+          |    +--- org.wordpress:aztec:v1.9.0 (*)
+          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.9.0 (*)
+          |    +--- org.wordpress.aztec:wordpress-comments:v1.9.0 (*)
+          |    +--- org.wordpress.aztec:glide-loader:v1.9.0
+          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+          |    |    +--- org.wordpress:aztec:v1.9.0 (*)
+          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)

Please review and act accordingly

Gerardo added 2 commits December 20, 2023 18:51

Gutenberg - Implement BackHandler to send back button events from Rea…

d91fcac

…ct Native

Update Gutenberg ref

6a56135

geriux added [Status] In Progress Gutenberg Editing and display of Gutenberg blocks. labels Dec 20, 2023

geriux mentioned this pull request Dec 20, 2023

[Mobile] Unselect blocks using the hardware back button (Android) WordPress/gutenberg#57279

Merged

geriux removed the [Status] In Progress label Dec 22, 2023

geriux added this to the 24.0 milestone Dec 22, 2023

geriux marked this pull request as ready for review December 22, 2023 08:40

geriux requested a review from fluiddot December 22, 2023 08:41

geriux self-assigned this Dec 22, 2023

fluiddot reviewed Dec 22, 2023

View reviewed changes

.../editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergContainerFragment.java Show resolved Hide resolved

WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java Outdated Show resolved Hide resolved

Gerardo added 5 commits December 22, 2023 12:13

Remove unneeded onEditorBackPressed implementation

9660150

Update logic to check if the editor should handle the back press logi…

0960294

…c or if it should just bubble up the events

Merge branch 'trunk' into gutenberg/implement-back-handler

34ab6db

Update Gutenberg ref

785349f

Update Release Notes

6816ce9

geriux force-pushed the gutenberg/implement-back-handler branch 2 times, most recently from 0bc2d87 to 6816ce9 Compare December 27, 2023 15:13

geriux changed the title ~~[Gutenberg] - Add support for BackHandler~~ [Gutenberg] - Add support for unselecting blocks with the hardware back button Dec 27, 2023

fluiddot approved these changes Jan 2, 2024

View reviewed changes

Gerardo added 3 commits January 2, 2024 16:39

Update Release notes to include Block editor prefix

76f654a

Update Gutenberg ref

5edcabd

Merge branch 'trunk' into gutenberg/implement-back-handler

56c03b3

geriux merged commit f40dc72 into trunk Jan 2, 2024
20 checks passed

geriux deleted the gutenberg/implement-back-handler branch January 2, 2024 19:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gutenberg] - Add support for unselecting blocks with the hardware back button #19828

[Gutenberg] - Add support for unselecting blocks with the hardware back button #19828

geriux commented Dec 20, 2023 •

edited

Loading

wpmobilebot commented Dec 20, 2023 •

edited

Loading

wpmobilebot commented Dec 20, 2023 •

edited

Loading

fluiddot left a comment

fluiddot Jan 2, 2024

wpmobilebot commented Jan 2, 2024

[Gutenberg] - Add support for unselecting blocks with the hardware back button #19828

[Gutenberg] - Add support for unselecting blocks with the hardware back button #19828

Conversation

geriux commented Dec 20, 2023 • edited Loading

To Test:

Regression Notes

PR Submission Checklist:

UI Changes Testing Checklist:

wpmobilebot commented Dec 20, 2023 • edited Loading

wpmobilebot commented Dec 20, 2023 • edited Loading

fluiddot left a comment

Choose a reason for hiding this comment

fluiddot Jan 2, 2024

Choose a reason for hiding this comment

wpmobilebot commented Jan 2, 2024

The PR caused the following dependency changes:

geriux commented Dec 20, 2023 •

edited

Loading

wpmobilebot commented Dec 20, 2023 •

edited

Loading

wpmobilebot commented Dec 20, 2023 •

edited

Loading