Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to image optimization settings #19581

Merged
merged 32 commits into from
Nov 23, 2023
Merged

Updates to image optimization settings #19581

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
648b1ac
Update strings associated with optimization popup
Nov 7, 2023
8f63328
Update RELEASE-NOTES
Nov 7, 2023
4aec270
Set "optimize image" setting to "on" by default
Nov 7, 2023
9d087f7
Update popup functionality to reflect new default
Nov 7, 2023
6f2190b
Show new promo in editor when adding local images
Nov 7, 2023
d7718a6
Introduce tracks event to monitor clicks
Nov 7, 2023
4a3985d
Display new popup after upload via media screen
Nov 8, 2023
4a41feb
Merge branch 'trunk' into feature/change-default-image-optimization-s…
Nov 8, 2023
af4406c
Remove duplicate case in switch statement
Nov 8, 2023
0134cc1
Add missing null check
Nov 8, 2023
29404be
Ensure media is uploaded if popup's not displayed
Nov 8, 2023
39fbd53
Revert unnecessary change to quality default
Nov 8, 2023
ff4fda6
Refactor popup logic for clarity
Nov 8, 2023
379da90
Update wording in popup
Nov 9, 2023
4f2b3fa
Merge pull request #19556 from wordpress-mobile/feature/change-defaul…
Nov 9, 2023
35f5adb
Merge branch 'trunk' into feature/updates-to-optimization-settings
Nov 10, 2023
ee30691
Merge branch 'trunk' into feature/updates-to-optimization-settings
Nov 21, 2023
eb71010
Fix positioning of RELEASE-NOTES entry
Nov 21, 2023
ab5d42c
Update values for low and medium image quality
Nov 21, 2023
452ed67
Update string names for accuracy
Nov 21, 2023
87d7db3
Update default max size to 2000 for optimized images
Nov 22, 2023
2a81cad
Reduce comment length for to pass linter rule
Nov 22, 2023
3df4817
Merge pull request #19648 from wordpress-mobile/feature/changes-to-de…
Nov 22, 2023
b649153
Merge branch 'feature/updates-to-optimization-settings' into feature/…
Nov 22, 2023
7109245
Add check to ensure quality value is valid
Nov 22, 2023
af19103
Import Context for use in class
Nov 22, 2023
acb9197
Ensure we return default quality int if necessary
Nov 23, 2023
bf8a7d7
Add extra detail to RELEASE-NOTES
Nov 23, 2023
b28e0dd
Merge pull request #19644 from wordpress-mobile/feature/update-optimi…
Nov 23, 2023
58bd339
Rename and reposition tracks event for clarity
Nov 23, 2023
40241df
Add additional line break to release notes
Nov 23, 2023
51ca8af
Refactor if statement
Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update values for low and medium image quality 
To match the default values for image quality for iOS (see: wordpress-mobile/WordPress-iOS#21981), this commit changes the defaults for quality to the following:

- Low = 70%
- Medium = 80%
  • Loading branch information
Siobhan committed Nov 21, 2023
commit ab5d42c1f8cea154ad0c2dcc46016f5d21d6170d
2 changes: 1 addition & 1 deletion WordPress/src/main/java/org/wordpress/android/util/WPMediaUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public interface LaunchCameraCallback {

// Max picture size will be 3000px wide. That's the maximum resolution you can set in the current picker.
public static final int OPTIMIZE_IMAGE_MAX_SIZE = 3000;
public static final int OPTIMIZE_IMAGE_ENCODER_QUALITY = 85;
public static final int OPTIMIZE_IMAGE_ENCODER_QUALITY = 80;
public static final int OPTIMIZE_VIDEO_MAX_WIDTH = 1280;
public static final int OPTIMIZE_VIDEO_ENCODER_BITRATE_KB = 3000;

Expand Down
2 changes: 1 addition & 1 deletion WordPress/src/main/res/values/key_strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,8 +364,8 @@
</string-array>

<string-array name="site_settings_image_quality_values" translatable="false">
<item>70</item>
<item>80</item>
<item>85</item>
<item>90</item>
<item>95</item>
<item>100</item>
Expand Down
Loading