-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Modernization Post: Remove post list compact layout #19424
Merged
AjeshRPai
merged 14 commits into
feature/ui-modernization-posts-and-pages
from
issue/19341-post-list-compact-layout
Oct 24, 2023
Merged
UI Modernization Post: Remove post list compact layout #19424
AjeshRPai
merged 14 commits into
feature/ui-modernization-posts-and-pages
from
issue/19341-post-list-compact-layout
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecause there is only a single layout for the post list.
… up a few redundant detekt issues
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
12 tasks
…341-post-list-compact-layout
Generated by 🚫 dangerJS |
AjeshRPai
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
AjeshRPai
merged commit Oct 24, 2023
72fdb73
into
feature/ui-modernization-posts-and-pages
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19340
This PR is the first in a series which will implement a new look/feel for the Post lists. This focus of this PR was to remove the "compact" layout and any associated logic. No visual changes in this PR.
Changes Include
-- Remove compact layout and drawable resources
- post_list_item_compact
- post_list_item_skeleton
- ic_view_post_compact_white_24dp
- ic_view_post_full_white_24dp
-- Remove
PostListViewLayoutType
-- Remove tracking layout type changes
-- Remove saving layout type preference
-- Remove
Compact
class-- Remove compact logic from
PostListMainViewModel
-- Remove unused dimen resources
-- Update unit tests
-- Search view now uses the base layout
To test:
Regression Notes
Potential unintended areas of impact
The app crashes when navigating to posts
What I did to test those areas of impact (or what existing automated tests I relied on)
Update unit tests
What automated tests I added (or what prevented me from doing so) N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: N/A