Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Modernization Post: Remove post list compact layout #19424

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Oct 22, 2023

Fixes #19340

This PR is the first in a series which will implement a new look/feel for the Post lists. This focus of this PR was to remove the "compact" layout and any associated logic. No visual changes in this PR.

Changes Include
-- Remove compact layout and drawable resources
- post_list_item_compact
- post_list_item_skeleton
- ic_view_post_compact_white_24dp
- ic_view_post_full_white_24dp
-- Remove PostListViewLayoutType
-- Remove tracking layout type changes
-- Remove saving layout type preference
-- Remove Compact class
-- Remove compact logic from PostListMainViewModel
-- Remove unused dimen resources
-- Update unit tests
-- Search view now uses the base layout

To test:

  • Install and launch the app
  • Login
  • Navigate from My Site > Posts
  • ✅ Verify that the post list works as expected
  • Tap the search icon and enter a search query
  • ✅ Verify that the search works as expected

Regression Notes

  1. Potential unintended areas of impact
    The app crashes when navigating to posts

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Update unit tests

  3. What automated tests I added (or what prevented me from doing so) N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist: N/A

@zwarm zwarm added this to the 23.6 milestone Oct 22, 2023
@zwarm zwarm requested a review from AjeshRPai October 22, 2023 18:18
@zwarm zwarm self-assigned this Oct 22, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 22, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19424-34fbe75
Commit34fbe75
Direct Downloadjetpack-prototype-build-pr19424-34fbe75.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 22, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19424-34fbe75
Commit34fbe75
Direct Downloadwordpress-prototype-build-pr19424-34fbe75.apk
Note: Google Login is not supported on these builds.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@AjeshRPai AjeshRPai merged commit 72fdb73 into feature/ui-modernization-posts-and-pages Oct 24, 2023
2 checks passed
@AjeshRPai AjeshRPai deleted the issue/19341-post-list-compact-layout branch October 24, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants