[Reader Improvements] Udate follow button design on "Manage Topics & Sites" screen

[RenanLukas]

Fixes #19326

This PR updates the follow/unfollow button design on "Manage Topics & Sites" screen. We've decided to keep the follow/unfollow button changes out of the feature flag, which means the new design will be shown regardless of the FF status.

To test:
1 - Run JP and sign in;
2 - Open reader;
3 - Tap the follow action on the toolbar to open the "Manage Topics & Sites" screen:

4 - Check both tabs ("Followed Topics" and "Followed Sites") to verify if the follow/unfollow button matches the design. Tap the buttons to make sure the follow/unfollow action is still working as expected;

Regression Notes

1. Potential unintended areas of impact
   None

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Manual testing

3. What automated tests I added (or what prevented me from doing so)
   Changes were only made to views

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[peril-wordpress-mobile]

	Warnings
⚠️	PR is not assigned to a milestone.

Generated by 🚫 dangerJS

[thomashorta]

Changes look good to me and it's working as designed! Nice! 🙇🏼

Only one minor comment:
I personally feel like that topbar icon is a bit misleading as it doesn't look like I will enter a "manage/settings" page. Would it make sense for it to be replaced by a "cog" icon or at least have a reader/follow icon with a cog instead of a checkmark? @osullivanchris

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19330-49b375c
	Commit	49b375c
	Direct Download	wordpress-prototype-build-pr19330-49b375c.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19330-49b375c
	Commit	49b375c
	Direct Download	jetpack-prototype-build-pr19330-49b375c.apk

Note: Google Login is not supported on these builds.

[osullivanchris]

Hey sorry I didn't get to reply sooner and save you some work, but I wouldn't bother changing this button at this time.

I personally feel like that topbar icon is a bit misleading as it doesn't look like I will enter a "manage/settings" page. Would it make sense for it to be replaced by a "cog" icon or at least have a reader/follow icon with a cog instead of a checkmark? @osullivanchris

I 100% agree this icon is confusing. But the whole experience around following tags and sites confusing. I'm working on a different iA/navigation which will try to solve this more thoroughly - not having this 'manage following' section so prominent, if at all. I think we could just wait and do it better overall, rather than having an icon change, then another change soon after. cc @develric

[osullivanchris]

left comment above but forgot to use this 'review' box

[osullivanchris]

Hey sorry I didn't get to reply sooner and save you some work, but I wouldn't bother changing this button at this time.

this was a misunderstanding before, specifically about the button in the "enter a URL" field.

Reviewing the list with updated buttons, it looks better @RenanLukas

One thing. When I unfollow. Typically in this situation I would expect the item to be unfollowed but to stay in the list for this session, with the button changed to "Follow". Helps with errors and visual validation. Then it would be gone the next time I open this screen.

If its hard to do, we can consider it for a later change.

[RenanLukas]

One thing. When I unfollow. Typically in this situation I would expect the item to be unfollowed but to stay in the list for this session, with the button changed to "Follow". Helps with errors and visual validation. Then it would be gone the next time I open this screen.

If its hard to do, we can consider it for a later change.

@osullivanchris after some investigation (thanks, @thomashorta) we realized that this is not an easy change. I'm creating an issue so this can be tracked.

#19353

[osullivanchris]

@osullivanchris after some investigation (thanks, @thomashorta) we realized that this is not an easy change. I'm creating an issue so this can be tracked.

No problem. Can be captured as a later task. I certainly wouldn't block the release waiting on this.