Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Reader Improvements #19267

Merged
merged 233 commits into from
Oct 16, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
233 commits
Select commit Hold shift + click to select a range
4766c75
Implement reader improvements feature flag
RenanLukas Aug 26, 2023
887674e
Add noto serif font to project
RenanLukas Aug 25, 2023
ec4d348
Update site header view design
RenanLukas Aug 26, 2023
149cefa
Merge pull request #19080 from wordpress-mobile/issue/19079-reader-im…
RenanLukas Aug 28, 2023
ebc2f3d
Implement empty toolbar title for site post list in Reader
RenanLukas Aug 26, 2023
31a5b0b
Fix reader site header avatar padding
RenanLukas Aug 26, 2023
1c1a2c6
Add reader improvements feature flag to site header layout
RenanLukas Aug 26, 2023
dc32562
Fix reader post list toolbar scroll flags
RenanLukas Aug 30, 2023
6ac72a9
Fix reader site header icon border size
RenanLukas Aug 30, 2023
2762453
Fix reader site header description emphasis
RenanLukas Aug 30, 2023
ede0386
Update reader post list activity back navigation icon from X to arrow
RenanLukas Aug 30, 2023
48d86ed
Remove share button from reader site header toolbar
RenanLukas Aug 30, 2023
7a2902a
Revert reader site header description emphasis to medium
RenanLukas Aug 30, 2023
eac2d1c
Hide reader site header icon if image URL is empty
RenanLukas Aug 30, 2023
6c1b531
Fix reader site header followers string
RenanLukas Aug 30, 2023
a7feef3
Fix lint: remove unused menu file share.xml
RenanLukas Aug 30, 2023
a789f47
Rename loadBlavatarImage -> showBlavatarImage
RenanLukas Aug 31, 2023
f189899
Update reader site header new design site icon placeholder
RenanLukas Aug 31, 2023
a91261d
Fix reader site header margins
RenanLukas Aug 31, 2023
edf35c4
Extract Reader header follow container to new file
RenanLukas Aug 28, 2023
a18a4b6
Extract reader header title style
RenanLukas Aug 28, 2023
9890449
Update tag header view design
RenanLukas Aug 28, 2023
d003bda
Add reader improvements feature flag to tag header layout
RenanLukas Aug 28, 2023
8fef5a3
Hide toolbar title for reader tag posts list
RenanLukas Aug 29, 2023
b9dcc6a
Fix DI inject call order
RenanLukas Aug 29, 2023
c3142a5
Fix reader tag posts list header margins
RenanLukas Aug 29, 2023
75f1f5e
Hide reader header follow count text by default
RenanLukas Aug 29, 2023
33d83a4
Update reader site header with extracted style
RenanLukas Aug 31, 2023
3189274
Replace follow button and followers label with extracted follow conta…
RenanLukas Aug 31, 2023
b8b9639
Hide followers count for reader tag header new design
RenanLukas Aug 31, 2023
3aba34e
Fix margin in reader tag header new design
RenanLukas Aug 31, 2023
9c694ec
Fix detekt
RenanLukas Aug 31, 2023
fa0af52
Fix checkstyle
RenanLukas Aug 31, 2023
213ca64
Update reader new tag header title
RenanLukas Sep 1, 2023
8268ecb
Revert "Remove share button from reader site header toolbar"
Sep 15, 2023
aa4e7f7
Revert "Fix lint: remove unused menu file share.xml"
Sep 15, 2023
8fa050e
Lint: fix usage of non-constant fields in switch/case
Sep 15, 2023
6e653b5
Remove visibility extensions in favor of androidx
Sep 15, 2023
91c3ffd
Merge pull request #19081 from wordpress-mobile/issue/19069-reader-im…
develric Sep 15, 2023
c82346a
Merge pull request #19126 from wordpress-mobile/issue/19069-reader-im…
develric Sep 15, 2023
c02080d
Merge branch 'trunk' of github.com:wordpress-mobile/WordPress-Android…
Sep 15, 2023
b8c3f19
Update Tag Header textAppearance to match i2 design
Sep 15, 2023
5be03cc
Update Site Header to match i2 design
Sep 15, 2023
c992c7c
Delete noto serif font from project (unused)
Sep 18, 2023
5708b34
Merge pull request #19200 from wordpress-mobile/issue/19077-reader-im…
Sep 18, 2023
25f6c05
Merge pull request #19201 from wordpress-mobile/issue/19069-reader-im…
Sep 18, 2023
dc713fe
Create new tag chip layout, styles, and resources
Sep 19, 2023
3930667
Create ChipStyle class to set tag style based on it
Sep 19, 2023
34ddb90
Make ChipStyle private
Sep 19, 2023
2b463ee
Remove wrong comment
Sep 20, 2023
d1a0149
Implement review comments to ChipStyle
Sep 20, 2023
9bbec2a
Merge pull request #19221 from wordpress-mobile/issue/19085-reader-ta…
Sep 20, 2023
37a17e5
Merge branch 'trunk' of github.com:wordpress-mobile/WordPress-Android…
Sep 21, 2023
4e35418
Create Blog Section styles and dimens
Sep 19, 2023
8d7bc90
Create blog section layout
Sep 19, 2023
41b0b49
Create Post Detail Header title style
Sep 19, 2023
d495879
Create Post Detail Header new layout
Sep 19, 2023
1735fae
Rename blog section dot separator view
Sep 20, 2023
c7b733c
Use new header layout when improvement config is enabled
Sep 20, 2023
e24cbaf
Remove unused state field
Sep 20, 2023
bf5a3d7
Fix chip spacing in new Post Details header
Sep 20, 2023
17e604c
Show author avatar in new header
Sep 20, 2023
99eb819
Fix left margin in blog section when no avatars visible
Sep 20, 2023
fb3302d
Hide browse and share items from topbar in Rader improvements
Sep 20, 2023
95d3160
Remove unnecessary ViewStub for alignment (review comment)
Sep 22, 2023
0178f5a
Add traling commas (review comment)
Sep 22, 2023
704b13c
Use sans-serif for post content in Reader Improvements
Sep 21, 2023
717c4fb
Merge pull request #19226 from wordpress-mobile/issue/19085-reader-im…
Sep 22, 2023
2c91347
Merge pull request #19234 from wordpress-mobile/feature/19227-post-de…
Sep 22, 2023
bad74cd
Create style for footer action button in Post Details
Sep 21, 2023
438acf4
Create layout for new post detail footer
Sep 21, 2023
cd37c66
Use ViewStub for lazy loading the desired bottom bar
Sep 22, 2023
7f63bb9
Rename some views in the new footer layout
Sep 22, 2023
2ed3a13
Fix snackbar overlapping bottom bar
Sep 22, 2023
9d950df
Create values-night/reader_styles.xml file
RenanLukas Sep 21, 2023
13137ae
Remove icon from ReaderFollowButton
RenanLukas Sep 23, 2023
1e900be
Update Reader follow button for light theme
RenanLukas Sep 23, 2023
ff635ba
Update Reader follow button for dark theme
RenanLukas Sep 23, 2023
4aad38b
Fix lint: remove unused dimen
RenanLukas Sep 23, 2023
1c79683
Fix lint: remove unused dimen
RenanLukas Sep 23, 2023
66a0c28
Remove unused file: on_secondary_on_background_selector.xml
RenanLukas Sep 23, 2023
50130e1
Remove unused color resources
RenanLukas Sep 23, 2023
4823ba2
Apply PR suggestion: update minHeight of Reader new follow button
RenanLukas Sep 25, 2023
e3b51af
Apply PR suggestion: fix margins in Reader site headers
RenanLukas Sep 25, 2023
780f0f4
Apply PR suggestion: fix new Reader follow button style shadow
RenanLukas Sep 25, 2023
99aed43
Apply PR suggestion: remove ReaderFollowButtonType
RenanLukas Sep 25, 2023
04a13f6
Fix lint: remove unused file
RenanLukas Sep 25, 2023
2c08a79
Fix lint error: remove unused file
RenanLukas Sep 26, 2023
788ca80
Hide follow/unfollow button in sites to follow section if reader impr…
RenanLukas Sep 23, 2023
270fcfd
Create separate layout for reader recommended blogs to be used when R…
RenanLukas Sep 23, 2023
7734218
Fix sites to follow new design: show new follow/unfollow button layout
RenanLukas Sep 24, 2023
8608366
Apply PR suggestion: rename ReaderRecommendedBlogBinding property
RenanLukas Sep 25, 2023
db08cd4
Apply PR suggestion: use new follow button style in the existing layo…
RenanLukas Sep 26, 2023
e3ff4c7
Implement new follow/unfollow button in post detail header when reade…
RenanLukas Sep 24, 2023
066bda0
Apply PR suggestion: fix follow button constraints on reader_post_det…
RenanLukas Sep 26, 2023
c7474cd
Apply PR suggestion: remove Reader.Follow.Button.PostDetail style and…
RenanLukas Sep 26, 2023
18546c1
Create new layout file for reader recommended blogs card. This view w…
RenanLukas Sep 24, 2023
2c5b09f
Revert changes on ReaderRecommendedBlogViewHolder
RenanLukas Sep 24, 2023
31b7335
Implement Reader sites to follow new layout
RenanLukas Sep 24, 2023
f6cea44
Update reader recommended sites header label
RenanLukas Sep 25, 2023
1e4b036
Apply PR suggestion: remove unnecessary class ReaderRecommendedBlogBi…
RenanLukas Sep 26, 2023
f95e863
Fix old reader recommended blog item bottom margin when site descript…
RenanLukas Sep 26, 2023
ac4ca31
Fix Reader new recommended blogs section item margins
RenanLukas Sep 26, 2023
d1427e3
Apply PR suggestions: fix new recommended sites section padding and p…
RenanLukas Sep 26, 2023
f5071f4
Apply PR suggestion: design fixes
RenanLukas Sep 26, 2023
abb0c81
Merge pull request #19246 from wordpress-mobile/issue/19078-reader-im…
RenanLukas Sep 26, 2023
30fdc7e
Merge pull request #19248 from wordpress-mobile/issue/19078-reader-im…
RenanLukas Sep 26, 2023
f1800e9
Merge pull request #19249 from wordpress-mobile/issue/19078-reader-im…
RenanLukas Sep 26, 2023
c282347
Apply PR suggestion: fix sites to follow card new design elevation
RenanLukas Sep 26, 2023
020adde
Merge pull request #19251 from wordpress-mobile/issue/19083-reader-im…
RenanLukas Sep 26, 2023
3f90684
PR comments: set footer BG color to surface color with no elevation
Sep 27, 2023
3258a3b
PR Comments: Hide new footer on scroll and set the BG of old footer
Sep 27, 2023
496ecf3
Fix detekt issue
Sep 27, 2023
f628cf2
PR comment: change top bar behavior to hide entirely on scroll
Sep 27, 2023
73556f7
Add the new icons for reader actions
Sep 27, 2023
bea18f9
PR comment: use isInvisible instead of View.INVISIBLE
Sep 27, 2023
0251983
Merge pull request #19243 from wordpress-mobile/issue/19227-improveme…
Sep 27, 2023
be7f619
Create base layout for reader post card
Sep 27, 2023
87860c4
Update reader post card footer button style
Sep 27, 2023
778811f
Update interaction counts style
Sep 28, 2023
16932a6
Create UI State for new Reader Post card
Sep 28, 2023
9108cdf
Create mapping from ReaderPost to new Post UI State
Sep 28, 2023
25e25c6
Create ReaderPostNewViewHolder for the new layout
Sep 28, 2023
c1610a8
Fix margin when no avatars visible in compact blog section
Sep 28, 2023
877f582
Add TODO
Sep 28, 2023
b3bfc87
Remove Disocver Attribution section from new card
Sep 29, 2023
de98455
Remove special treatment for photo (photo title)
Sep 29, 2023
30dd369
Remove featured image border and adjust rounded corner
Sep 29, 2023
345c03f
Hide disabled actions in post card
Sep 29, 2023
2435c63
Reduce spacing between cards in reader
Sep 29, 2023
e2480e3
Add surface background to compact blog section avatars
Sep 29, 2023
0fff708
Don't try to make up post title from excerpt
Sep 29, 2023
40798c9
Set aspect ratio to 16:9 in new layout to match code
Sep 29, 2023
23332ff
Add bookmark action to the more menu in post card
Sep 29, 2023
f40a187
Fix detekt issues
Sep 29, 2023
e6874f6
Implement Reader tags to follow new layout
RenanLukas Sep 28, 2023
5c99836
Remove TODO as we will keep using the current logic
Oct 2, 2023
a46d6a9
Create InteractionSectionData for like and comment count
Oct 2, 2023
89de4e1
Apply PR suggestion: change tag text color to high emphasis
RenanLukas Oct 2, 2023
7127700
Remove unused attr: wpReaderFollowButtonType
RenanLukas Oct 2, 2023
75f6652
Fix like and comment content descriptions in post card
Oct 2, 2023
f5bb9a2
Implement Following button new design
RenanLukas Oct 2, 2023
800fa2a
Fix broken unit tests
Oct 3, 2023
679ba47
Apply PR suggestion: fix last last chip in the same line has wrong h…
RenanLukas Oct 3, 2023
5e6edc3
Merge branch 'issue/19083-reader-improvements-new-design-tags-you-mig…
RenanLukas Oct 3, 2023
cc053d4
Add unit test to ReaderDiscoverViewModel
Oct 3, 2023
dd3fa55
Add unit tests to ReaderPostMoreButtonUiStateBuilder
Oct 3, 2023
dd12ac6
Remove click callback in blog section for blog preview feed
Oct 3, 2023
a5d4535
Fix unit tests
Oct 3, 2023
5ceacef
Add blog header unit tests for ReaderPostUiStateBuilder
Oct 3, 2023
7ac5312
Add video unit tests for ReaderPostUiStateBuilder
Oct 3, 2023
553ba12
Add thumbnail strip unit tests for ReaderPostUiStateBuilder
Oct 3, 2023
1bd3f0f
Add featured image unit tests for ReaderPostUiStateBuilder
Oct 3, 2023
3961719
Remove unused photoFrameVisibility field
Oct 3, 2023
920f5f0
Remove photo frame unit tests for ReaderPostUiStateBuilder
Oct 3, 2023
69cf53c
Fix broken unit tests
Oct 3, 2023
d6b235d
Add title unit tests for ReaderPostUiStateBuilder
Oct 3, 2023
0f3ce1b
Add excerpt unit tests for ReaderPostUiStateBuilder
Oct 3, 2023
4cb8691
Add blog name unit tests for ReaderPostUiStateBuilder
Oct 3, 2023
ff2db22
Add dateline unit test for ReaderPostUiStateBuilder
Oct 3, 2023
fe81fad
Add like button unit tests for ReaderPostUiStateBuilder
Oct 3, 2023
11674ff
Add reblog button unit tests for ReaderPostUiStateBuilder
Oct 3, 2023
d633422
Add comment button unit tests for ReaderPostUiStateBuilder
Oct 3, 2023
f4d8d63
Add iteraction section unit tests for ReaderPostUiStateBuilder
Oct 3, 2023
78e3789
Fix ripple effect on follow button
RenanLukas Oct 4, 2023
e3d0f47
Apply PR suggestion: improve ripple color of Follow button
RenanLukas Oct 4, 2023
7b2a8f5
Create new UI layout for X-Post card
Oct 4, 2023
edfbc58
Use new layout for X-post for reader improvements
Oct 4, 2023
f137d84
Fix default post card blog section to match avatar positions
Oct 4, 2023
1689674
Remove Discover Welcome card and everything related
Oct 4, 2023
e648133
Create new layout with a sans-serif font for removed post card
Oct 5, 2023
83deed6
retrigger CI
Oct 5, 2023
1a72b4b
Fix android instrumented test
Oct 5, 2023
111985d
Merge pull request #19287 from wordpress-mobile/issue/19082-reader-im…
Oct 5, 2023
1366ee0
Merge branch 'feature/reader-improvements' into issue/19083-reader-im…
RenanLukas Oct 5, 2023
b00b0ab
Apply PR suggestion: extract interest tag to new style
RenanLukas Oct 5, 2023
72510b3
Merge pull request #19281 from wordpress-mobile/issue/19083-reader-im…
RenanLukas Oct 5, 2023
536f65e
Merge pull request #19292 from wordpress-mobile/issue/19260-update-fo…
RenanLukas Oct 5, 2023
c2b92a1
Set ellipsize to end (PR review comments)
Oct 6, 2023
7d6179b
Use ternary for choosing layout res (PR review comments)
Oct 6, 2023
1c54c05
Allow up to 6 items in the recommended tags card
Oct 6, 2023
f6d9069
Merge pull request #19327 from wordpress-mobile/issue/19083-reader-im…
Oct 6, 2023
a62fd1e
Merge pull request #19310 from wordpress-mobile/issue/19082-reader-im…
Oct 6, 2023
5f3b77e
Add surface-colored background and border in post details avatars
Oct 6, 2023
c1dd284
Add internal 0.5dp border of opposite color on top of avatars
Oct 6, 2023
751f22c
Replace follow button with new design on manage followed topics
RenanLukas Oct 6, 2023
7b95b8e
Replace follow button with new design on manage followed sites
RenanLukas Oct 6, 2023
72554ef
Merge branch 'feature/reader-improvements' of github.com:wordpress-mo…
Oct 6, 2023
4ee819d
Merge branch 'feature/reader-improvements' of github.com:wordpress-mo…
Oct 6, 2023
83afa43
Remove unused resources
Oct 6, 2023
663874a
Merge pull request #19300 from wordpress-mobile/issue/19082-reader-im…
Oct 6, 2023
8c6f93d
Use 20% opacity for the avatar internal border
Oct 9, 2023
49b375c
Remove unused dimension: reader_remove_button_extra_padding
RenanLukas Oct 9, 2023
229bea4
Merge branch 'feature/reader-improvements' of github.com:wordpress-mo…
Oct 9, 2023
ddf9970
Create ReaderCardViewNew style
Oct 9, 2023
e57b7ae
Remove extra spacing added by FilteredRecyclerView
Oct 9, 2023
61cfdd9
Use new Card style in all new card layouts
Oct 9, 2023
b6dde10
Add helper methods for adding a divider using the res ID
Oct 9, 2023
f16ddbe
Update reader feed background and item divider
Oct 9, 2023
31f9d7d
Set the toolbar BG to colorSurface in reader post lists
Oct 9, 2023
7298433
Hide item divider around recommendation cards in Discover tab
Oct 10, 2023
ed5a5f5
Simplify layout logic (PR review comments)
Oct 10, 2023
03e85dc
Merge pull request #19299 from wordpress-mobile/issue/19082-reader-im…
Oct 10, 2023
6de2cbf
Merge branch 'feature/reader-improvements' of github.com:wordpress-mo…
Oct 10, 2023
ce2a994
Add internal borders to all avatars in new cards/headers
Oct 10, 2023
6edada7
Merge pull request #19328 from wordpress-mobile/issue/19212-reader-po…
Oct 10, 2023
bcaecf7
Merge branch 'feature/reader-improvements' of github.com:wordpress-mo…
Oct 10, 2023
2120b95
Use M3 BodyMedium for Excerpt, Interactions, and Actions
Oct 10, 2023
65b12e6
Use M3 TitleLarge for Title
Oct 10, 2023
cdc15e2
Change spacing between footer actions to 16dp
Oct 10, 2023
0c6f7a3
Merge pull request #19329 from wordpress-mobile/issue/19272-reader-po…
Oct 10, 2023
eba9be3
Merge pull request #19330 from wordpress-mobile/issue/19326-update-fo…
RenanLukas Oct 10, 2023
7d0b279
Fix icon follow buton size on manage topics and sites screen
RenanLukas Oct 11, 2023
04324af
Merge branch 'trunk' into feature/reader-improvements
RenanLukas Oct 11, 2023
6e0368c
Apply PR suggestion: use medium font weight for post card titles
RenanLukas Oct 11, 2023
3744203
Merge pull request #19354 from wordpress-mobile/issue/fix-follow-butt…
Oct 12, 2023
0a486f6
Merge pull request #19352 from wordpress-mobile/issue/19337-reader-po…
Oct 12, 2023
5f06569
Fix follow/unfollow button responsiveness on reader site header
RenanLukas Oct 12, 2023
fa178f9
Add isFollowEnabled field to Recommended Blog UI state
Oct 12, 2023
28b856f
Add isChangeFinal field to FollowStatusChanged
Oct 12, 2023
5943987
Update Follow button status for recommended blog Discover cards
Oct 12, 2023
207bb26
Use isChangeFinal in PostDetail header to enable/disable follow button
Oct 12, 2023
17a7920
Fix broken unit tests
Oct 12, 2023
d85453f
Refactor ReaderDiscoverViewModel init
Oct 12, 2023
bc2a239
Default ReaderImprovementsFeatureConfig (reader_improvements) to ON
Oct 13, 2023
03be7cf
Update bookmark UI test for reader improvements
Oct 13, 2023
c2361c8
Merge pull request #19363 from wordpress-mobile/issue/19307-fix-follo…
Oct 13, 2023
a1a5b80
Merge pull request #19371 from wordpress-mobile/issue/19370-reader-im…
Oct 13, 2023
10e8688
Update 23.5 RELEASE-NOTES to include reader improvements
RenanLukas Oct 14, 2023
f4fface
Merge pull request #19375 from wordpress-mobile/issue/update-release-…
develric Oct 14, 2023
9a544e9
Merge branch 'trunk' into feature/reader-improvements
develric Oct 14, 2023
fd18881
Adding missing URL to RELEASE-NOTES.txt
develric Oct 14, 2023
d6f9c68
Adding [Jetpack-only] in RELEASE-NOTES for reader changes entry
develric Oct 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update reader site header new design site icon placeholder
  • Loading branch information
RenanLukas committed Aug 31, 2023
commit f1898996a1be6f7b2d71f518ae483f6e2be9f931
20 changes: 20 additions & 0 deletions WordPress/src/main/res/drawable/bg_oval_placeholder_image_32dp.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?xml version="1.0" encoding="utf-8"?>
<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
<item>
<shape android:shape="oval">
<solid
android:color="@color/placeholder">
</solid>
</shape>

</item>

<item
android:drawable="@drawable/ic_image_placeholder_24dp"
android:bottom="4dp"
android:left="4dp"
android:right="4dp"
android:top="4dp">
</item>

</layer-list>
9 changes: 9 additions & 0 deletions WordPress/src/main/res/drawable/ic_image_placeholder_24dp.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="24dp"
android:height="24dp"
android:viewportHeight="24"
android:viewportWidth="24">
<path
android:fillColor="#80000000"
android:pathData="M12,3C7,3 3,7 3,12C3,17 7,21 12,21C17,21 21,17 21,12C21,7 17,3 12,3ZM12,4.5C16.1,4.5 19.5,7.9 19.5,12V12.1C18.1,11.3 16.2,10.4 16.1,10.3C15.9,10.2 15.6,10.2 15.3,10.4L12.4,12.5L9,11.3C8.8,11.2 8.6,11.3 8.4,11.4L4.7,13.6C4.6,13.1 4.5,12.6 4.5,12.1C4.5,7.9 7.9,4.5 12,4.5ZM12,19.5C8.9,19.5 6.3,17.6 5.1,15L8.8,12.8L12.3,14C12.5,14.1 12.8,14 13,13.9L15.9,11.8C16.7,12.2 18.4,13 19.4,13.7C18.5,17 15.5,19.5 12,19.5Z" />
</vector>
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
android:background="@drawable/bg_oval_placeholder"
android:contentDescription="@null"
android:padding="@dimen/reader_site_header_avatar_padding_new"
android:src="@drawable/bg_oval_placeholder_globe_no_border_24dp"
android:src="@drawable/bg_oval_placeholder_image_32dp"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />

Expand Down