Skip to content

Conversation

@zwarm
Copy link
Contributor

@zwarm zwarm commented May 26, 2023

This PR migrates the following remote config fields from Firebase Remote Config to our BE remote config

  • open_web_links_with_jetpack_flow_frequency
  • codeable_get_free_estimate_url
  • wp_android_performance_monitoring_sample_rate

A new remote config class was created for each field and default values set:

  • OpenWebLinksWithJetpackFlowFrequencyConfig
  • CodeableGetFreeEstimateUrlConfig
  • PerformanceMonitoringSampleRateConfig

Default local value and remote config values are set as follows:
wp_android_performance_monitoring_sample_rate = 0.0
codeable_get_free_estimate_url = https://codeable.io/partners/jetpack-scan/
open_web_links_with_jetpack_flow_frequency = 0
FYI: @oguzkocer and @AjeshRPai - Please verify the default values are correct

  • Deleted FirebaseRemoteConfigWrapper and replaced it with RemoteConfigWrapper
  • Removed the FirebaseConfig dependency. @ParaskP7 🤞 that this was okay. Unless there is a dependency in a library that I am unaware of. Want to give this a second set of eyes?

To test:
Note: The default values are the same across local and remote.

  • Install the app
  • Login in
  • Navigate to Me > App Settings > Privacy Settings
  • Enable Collect Information
  • Swipe closed the app
  • Launch the app
  • ✅ Validate 🔵 Tracked: remote_field_config_synced_state log item contains the new fields:
    "open_web_links_with_jetpack_flow_frequency":"0",
    "wp_android_performance_monitoring_sample_rate":"0.0",
    "codeable_get_free_estimate_url":"https://codeable.io/partners/jetpack-scan/"
  • Navigate to App Settings > Debug Settings
  • ✅ Validate the following fields are shown as "REMOTE" under the Remote Field Configs sections
- open_web_links_with_jetpack_flow_frequency
- codeable_get_free_estimate_url
- wp_android_performance_monitoring_sample_rate 

Regression Notes

  1. Potential unintended areas of impact
    The default values are used for remote config values

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Unit testing

  3. What automated tests I added (or what prevented me from doing so)
    Updated existing unit tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist: N/A

@zwarm zwarm added this to the 22.5 milestone May 26, 2023
@zwarm zwarm requested a review from AjeshRPai May 26, 2023 21:01
@zwarm zwarm self-assigned this May 26, 2023
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

-\--- com.google.firebase:firebase-config:19.1.3
-     +--- com.google.firebase:firebase-abt:19.0.1
-     |    +--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
-     |    +--- com.google.firebase:firebase-common:19.3.0 -> 19.5.0 (*)
-     |    +--- com.google.firebase:firebase-components:16.0.0 -> 16.1.0 (*)
-     |    +--- com.google.firebase:firebase-measurement-connector:18.0.0 (*)
-     |    \--- com.google.protobuf:protobuf-lite:3.0.1
-     +--- com.google.firebase:firebase-common:19.3.0 -> 19.5.0 (*)
-     +--- com.google.firebase:firebase-components:16.0.0 -> 16.1.0 (*)
-     +--- com.google.firebase:firebase-iid:20.0.1 -> 21.1.0 (*)
-     +--- com.google.firebase:firebase-measurement-connector:18.0.0 (*)
-     \--- com.google.protobuf:protobuf-lite:3.0.1

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18537-01f5b01
Commit01f5b01
Direct Downloadwordpress-prototype-build-pr18537-01f5b01.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18537-01f5b01
Commit01f5b01
Direct Downloadjetpack-prototype-build-pr18537-01f5b01.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @zwarm @AjeshRPai !

I have reviewing and tested this PR as per the instructions, thank you both so much for working on that and migrating Firebase Remote Config to our BE Remote Config, you rock! 🌟 ❤️ 🌟

FYI: I am approving but not merging this to give the change to @AjeshRPai to review this too, that is, before merging to trunk. No matter, feel free to merge it at any point in time, if you feel comfortable doing so. 🚀

Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zwarm

I have reviewed and tested the PR according to the test instructions. Everything Looks good to me 👍🏼

@AjeshRPai AjeshRPai merged commit 8a2057d into trunk May 29, 2023
@AjeshRPai AjeshRPai deleted the issue/migrate-fb-remote-config-to-be branch May 29, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants