Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable overscroll animation on main plugins screen #18498

Merged
merged 2 commits into from
May 24, 2023

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented May 24, 2023

Fixes #14087

Description

This PR disables the overscroll animation on the main plugin screen. This is done because it seems that the animation may lead to the expectation that swiping down will refresh the contents of this screen. In fact, this screen does not have a multi-list refresh implemented, and each individual plugins list can be refreshed by tapping into the detail view.

To test:

  1. Login to an account with an Atomic site (with plugins enabled)
  2. Select that Atomic site from the My Sites list
  3. Navigate to the main plugins screen (Menu tab -> Plugins)
  4. Wait for the plugins screen to load
  5. Swipe down
  6. Expect that the overscroll animation is disabled

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

This is done because it seems that the animation may lead to the
expectation that swiping down will refresh the contents of this screen.
In fact, this screen does not have a multi-list refresh implemented, and
each individual plugins list can be refreshed by tapping into the detail
view.
@mkevins mkevins added this to the 22.5 milestone May 24, 2023
@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18498-bf86ba1
Commitbf86ba1
Direct Downloadjetpack-prototype-build-pr18498-bf86ba1.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18498-bf86ba1
Commitbf86ba1
Direct Downloadwordpress-prototype-build-pr18498-bf86ba1.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this @mkevins 🙇
I agree with your reasoning on resolving this issue 👍
The code changes LGTM and the app behaves as expected 🎉

device-2023-05-24-112817.mp4

@antonis antonis merged commit b6696b4 into trunk May 24, 2023
@antonis antonis deleted the issue/14087-disable-overscroll-on-main-plugins-screen branch May 24, 2023 08:29
@mkevins
Copy link
Contributor Author

mkevins commented May 24, 2023

Thank you for reviewing and testing this Antonis, and for considering the reasoning behind the choice of solution. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull-to-refresh not working on plugins screen
3 participants