Add account closure tracks events #18444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-to-flow' into feature/enable-account-closure--18413-add-tracks-events
…g-to-flow' into feature/enable-account-closure--18413-add-tracks-events
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18444-a6cd729 | |
| Commit | a6cd729 | |
| Direct Download | jetpack-prototype-build-pr18444-a6cd729.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18444-a6cd729 | |
| Commit | a6cd729 | |
| Direct Download | wordpress-prototype-build-pr18444-a6cd729.apk |
antonis
approved these changes
May 17, 2023
There was a problem hiding this comment.
Great work @mkevins 👍
I've tested the implementation on my device and the events are emitted as expected in both cases. The code changes also look good 🎉
ps. I've noticed a failing tests in AccountSettingsViewModelTest due to a compilation error. Since this change was introduced in the error handling PR I don't consider this a blocker for this one.
ovitrif
approved these changes
May 17, 2023
ovitrif
merged commit 65b2522
into
feature/enable-account-closure--18406-add-error-handling-to-flow
ovitrif
deleted the
feature/enable-account-closure--18413-add-tracks-events
branch
|
Thank you Antonis and Ovi for reviewing and testing! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18413
To test:
Please test using the steps in the feature branch PR description.
PR submission checklist:
See feature branch PR for checklist.