Add a confirmation dialog for account closure (addendum) #18391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resumes the normal dialog after a three second delay for the purpose of testing the ui, and will be wired up to the real implementation after the FluxC changes are available.
12 tasks
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18391-8bb341f | |
| Commit | 8bb341f | |
| Direct Download | wordpress-prototype-build-pr18391-8bb341f.apk |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18391-8bb341f | |
| Commit | 8bb341f | |
| Direct Download | jetpack-prototype-build-pr18391-8bb341f.apk |
ovitrif
approved these changes
May 9, 2023
There was a problem hiding this comment.
Thanks for adding this final piece of the puzzle @mkevins 🙇🏻
In testing it works as expected, and the code looks good to me!
I left a minor np for a bit of a cleanup to make the code easier to read (imho). My testing was done after doing the suggested cleanup, and there was no issue so from my side you can freely merge the PR after you apply the change (or just merge it without, It's not really critical, just a nice-to-have coding wise) 🙇🏻
...ess/src/main/java/org/wordpress/android/ui/prefs/accountsettings/AccountSettingsViewModel.kt
Outdated
Show resolved
Hide resolved
|
Thank you for reviewing and testing the addendum so quickly Ovi! |
mkevins
deleted the
feature/enable-account-closure--18381-add-confirmation-dialog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an addendum to #18386 to include commits that were not pushed. It should address the second issue reported there. I forgot to push these commits yesterday 🙃 .
To test:
Same as: #18386