Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader] Add support to Prompt block #18323

Merged
merged 7 commits into from
Apr 27, 2023
Merged

[Reader] Add support to Prompt block #18323

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4aa5b9e
add margin-right to Reader body to avoid 1 px cutoff
Apr 24, 2023
a220d5e
add --color-neutral-5 to Reader css colors
Apr 25, 2023
2cafbeb
intercept tag URLs from the post content
Apr 25, 2023
83bee88
add unit test to ReaderPostDetailViewModel
Apr 25, 2023
60743d5
fix detekt issues
Apr 25, 2023
392ea5f
fix checkstyle checks
Apr 25, 2023
95047a7
add unit tests to ReaderUtils
Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add --color-neutral-5 to Reader css colors 
Reuse an existing color from `mResourceVars` since it is the one that most
closely resembles the --color-neutral-5 used on web (gray-5).
  • Loading branch information
Thomas Horta committed Apr 25, 2023
commit a220d5e99538bbae8421b523f48ca7984b5f4f0f
7 changes: 4 additions & 3 deletions WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,12 +540,13 @@ private String formatPostContentForWebView(final String content, final Set<Strin
private void appendMappedColors(StringBuilder sb) {
sb.append(" :root { ")
.append("--color-text: ").append(mResourceVars.mTextColor).append("; ")
.append("--color-neutral-70: ").append(mResourceVars.mTextColor).append("; ")
.append("--color-neutral-0: ").append(mResourceVars.mGreyMediumDarkStr).append("; ")
.append("--color-neutral-50: ").append(mResourceVars.mGreyLightStr).append("; ")
.append("--color-neutral-5: ").append(mResourceVars.mGreyExtraLightStr).append("; ")
.append("--color-neutral-10: ").append(mResourceVars.mGreyDisabledStr).append("; ")
.append("--color-neutral-20: ").append(mResourceVars.mGreyExtraLightStr).append("; ")
.append("--color-neutral-50: ").append(mResourceVars.mGreyLightStr).append("; ")
.append("--color-neutral-70: ").append(mResourceVars.mTextColor).append("; ")
.append("--main-link-color: ").append(mResourceVars.mLinkColorStr).append("; ")
.append("--color-neutral-10: ").append(mResourceVars.mGreyDisabledStr).append("; ")
.append("} ");
}

Expand Down