Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Card Domain: Do not show card on P2s #18313

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

ravishanker
Copy link
Contributor

This PR adds a condition to not show card on P2s

Fixes #18293

To test:

Before After
Screenshot_20230424_080026 Screenshot_20230424_080741

To test:

  • Launch Jetpack/WordPress app
  • Verify domain card appears as shown above on dashboard for P2s as in Before
  • Launch this version of JP/WP app
  • Verify domain card doesn't show now on P2s as in after above

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested for conditions

  3. What automated tests I added (or what prevented me from doing so)
    Existing unit tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Do not show card on P2s
@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18313-7da4263
Commit7da4263
Direct Downloadwordpress-prototype-build-pr18313-7da4263.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18313-7da4263
Commit7da4263
Direct Downloadjetpack-prototype-build-pr18313-7da4263.apk
Note: Google Login is not supported on these builds.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@irfano irfano merged commit 3a4112e into trunk Apr 24, 2023
@irfano irfano deleted the Dasbhboard-Card-Domain---Do-not-show-card-on-P2s branch April 24, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domains Dashboard Card: Hide for P2 (WP for teams)
3 participants