Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Cards: Activity Card tweak UI #18309

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Apr 21, 2023

Closes #18307

This PR tweaks the Activity Card UI

  • Tightens spacing
  • Decreases icon size from 48dp to 40dp to match the Activity Log list view
Before Light After Light
Alt desc Alt desc
Before Dark After Dark
Alt desc Alt desc

To test:

  1. Install the Jetpack app
  2. Login with a wp account
  3. Select a site in which you can access the activity log (manage content/admin)
  4. Navigate to App Setting > Debug Settings
  5. Enable dashboard_card_activity_log and restart the app
  6. Navigate to Home
  7. ✅ Verify that the activity card is matches the requested changes

Regression Notes

  1. Potential unintended areas of impact
    Activity card does not have enough spacing

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 22.3 milestone Apr 21, 2023
@zwarm zwarm requested review from enejb and osullivanchris April 21, 2023 18:19
@zwarm zwarm self-assigned this Apr 21, 2023
@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18309-1f94475
Commit1f94475
Direct Downloadjetpack-prototype-build-pr18309-1f94475.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18309-1f94475
Commit1f94475
Direct Downloadwordpress-prototype-build-pr18309-1f94475.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new icons size looks good!

@enejb
Copy link
Contributor

enejb commented Apr 21, 2023

I think the new icon size does match.
I think in a future PR it would be good to also match the fonts.

@zwarm
Copy link
Contributor Author

zwarm commented Apr 24, 2023

I think the new icon size does match.

🥳

I think in a future PR it would be good to also match the fonts.

I think we need an overhaul on the entire dashboard - the fonts are all over the place. :( For this card, I am using the styles defined for the other dashboard cards (posts)

Copy link

@osullivanchris osullivanchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better thanks.

@zwarm that's correct, the type sizes should follow My Site Home dashboard, not activity log.

Agree type sizes look messy on Android right now. Intention was to have only 2 or 3. A case of a few too many designers and a few developers and missed communications. A good example for the design system discussion lately. Think we can revisit separately.

@zwarm zwarm merged commit d0627d8 into trunk Apr 24, 2023
@zwarm zwarm deleted the issue/18307-activity-card-ui-tweaks branch April 24, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard Cards: Activity Card Tweak UI
4 participants