-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard Cards: Activity Card tweak UI #18309
Conversation
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new icons size looks good!
🥳
I think we need an overhaul on the entire dashboard - the fonts are all over the place. :( For this card, I am using the styles defined for the other dashboard cards (posts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better thanks.
@zwarm that's correct, the type sizes should follow My Site Home dashboard, not activity log.
Agree type sizes look messy on Android right now. Intention was to have only 2 or 3. A case of a few too many designers and a few developers and missed communications. A good example for the design system discussion lately. Think we can revisit separately.
Closes #18307
This PR tweaks the Activity Card UI
To test:
dashboard_card_activity_log
and restart the appRegression Notes
Potential unintended areas of impact
Activity card does not have enough spacing
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.