Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard card domain navigation #18301

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

ravishanker
Copy link
Contributor

@ravishanker ravishanker commented Apr 21, 2023

Pass domain_purchase parameter to list prices, and not as free

Before After
Screenshot_20230421_141050 Screenshot_20230421_140158

Fixes #

To test:

  • Launch Jetpack/WordPress app
  • Verify domain card appears on the dashboard
  • Tap on domain card
  • Verify that it launches domains search
  • Verify it shows prices listed for domains, and not free as before

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested manually

  3. What automated tests I added (or what prevented me from doing so)
    Existing unit tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Pass domain_purchase parameter to list prices and not as free
@ravishanker ravishanker added this to the 22.2 ❄️ milestone Apr 21, 2023
@ravishanker ravishanker requested a review from staskus April 21, 2023 04:11
@ravishanker ravishanker self-assigned this Apr 21, 2023
@ravishanker ravishanker marked this pull request as ready for review April 21, 2023 04:12
@ravishanker ravishanker requested a review from irfano April 21, 2023 04:12
@ravishanker
Copy link
Contributor Author

👋 @oguzkocer - Could we please include it in the 22.2-rc-2? 🙇

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18301-cb7d650
Commitcb7d650
Direct Downloadjetpack-prototype-build-pr18301-cb7d650.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18301-cb7d650
Commitcb7d650
Direct Downloadwordpress-prototype-build-pr18301-cb7d650.apk
Note: Google Login is not supported on these builds.

@staskus
Copy link
Contributor

staskus commented Apr 21, 2023

Thanks!

✅ Correct Domains purchasing view appears
✅ The flow from tapping the card to making a purchase works

@irfano irfano self-assigned this Apr 21, 2023
Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@irfano irfano merged commit 80f945f into release/22.2 Apr 21, 2023
@irfano irfano deleted the Dasboard-Card-Domains-Fix-Navigation branch April 21, 2023 17:44
@oguzkocer
Copy link
Contributor

👋 @oguzkocer - Could we please include it in the 22.2-rc-2? 🙇

@ravishanker 22.2-rc-2 is already published, but I can publish 22.2-rc-3 soon. We have a couple more fixes targeting the release branch, so I'll wait for them to be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants