-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement selected domain UI #18295
Implement selected domain UI #18295
Conversation
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good, and the code changes look great. Nice work Ovi!
A minor observation I had (though seemingly unrelated with this PR): When I have selected a domain, and then tap back to go back to the theme selection screen, pick a theme again, and return back to the domain search screen, the search input is empty, but the previous results (including the selected domain) are still present. Also, the "Purchase domain" button is still visible. Maybe this is expected, but it felt weird since the search input was still empty. Is this expected behavior?
Thank you for finding this and reporting it @mkevins 🙇🏻 !
It doesn't feel "expected" to me, but upon checking in production I found it repro's: 🎬 Prod repro scenariorec.mp4Given the fact that it's in production for a long time, my suggestion going forward is to ignore it for now (cc. @antonis) 🙏🏻 |
I agree that this should not be blocking 👍 Let's open an issue to track this down thought. |
I've opened an issue to track this: #18311 |
Resolves #17901
This PR:
To Test
Prerequisite
◐ Toggle the
SiteCreationDomainPurchasingFeatureConfig
flagMe
→App Settings
→Debug settings
Features in development
sectionRESTART THE APP
button● Treatment Variation · flag
ON
Verify UI for selected domain matches the design specs
My Site
↓
arrow at the right of the site name+
at the top right⊕ Create WordPress.com site
buttonRegression Notes
Potential unintended areas of impact
N/a - new functionality behind feature flag
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing and unit testing
What automated tests I added (or what prevented me from doing so)
Unit test in
SiteCreationDomainsViewModelTest
PR submission checklist:
RELEASE-NOTES.txt
if necessary.n/a
UI Changes testing checklist