-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard Cards: Activity Card rearrange content in card #18292
Conversation
…_reorder_title_content
…_reorder_title_content
…_reorder_title_content
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this PR since the change only update some sementic code.
Over all this worked really well. Some things that I noticed that are a bit strange to me.
|
Thanks @enej for testing!!!
They are, it just takes a little time for the app to catch up when the language is changed on the fly. Close the app and relaunch it, you should see the icons on the right. Like this:
That is odd and something I haven't been experiencing in my testing. Both views are endpoint driven, but from different endpoints. I wonder if there is a difference in what type of site you are using. I've used AT, free, and business so far.
The navigation actions are not hooked up in this PR. I'll add a note in the description above. :) |
👋 Hey @zwarm mostly looking as expected, nice stuff. Two small details:
|
Can do @osullivanchris . I created a new issue to track it. 🙇 |
Closes #18210
This PR focuses on:
(1) Swapping the label/sub-label of activity items within the card
(2) Renaming the label fields in the layout and associated files
(2) Minor refactoring of the XML layout file - removing inner constraint layout and deprecated attributes, consolidating padding/margin settings
NOTE: The navigation clicks are not enabled in this build.
To test:
Make sure the activity card item list shows the "content" as the label and "summary" as sublabel
dashboard_card_activity_log
and restart the appSee UI Changes testing checklist below. Note: I have already been through the list before submitting this PR
cc: @startuptester
cc: @osullivanchris - Can you take a look and see if I have missed anything with regards to design/layout, etc?. Thanks.
Regression Notes
Potential unintended areas of impact
The items in the activity card are not displayed properly
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: