Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Cards: Activity Card rearrange content in card #18292

Merged
merged 9 commits into from
Apr 20, 2023

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Apr 20, 2023

Closes #18210

This PR focuses on:
(1) Swapping the label/sub-label of activity items within the card
(2) Renaming the label fields in the layout and associated files
(2) Minor refactoring of the XML layout file - removing inner constraint layout and deprecated attributes, consolidating padding/margin settings

Light Dark
Alt desc Alt desc

NOTE: The navigation clicks are not enabled in this build.

To test:
Make sure the activity card item list shows the "content" as the label and "summary" as sublabel

  1. Install the Jetpack app
  2. Login with a wp account
  3. Select a site in which you can access the activity log (manage content/admin)
  4. Navigate to App Setting > Debug Settings
  5. Enable dashboard_card_activity_log and restart the app
  6. Navigate to Home
  7. ✅ Verify that the activity card is shown
  8. ✅ Verify the card matches the design in this PR and figma design docs

See UI Changes testing checklist below. Note: I have already been through the list before submitting this PR

cc: @startuptester

cc: @osullivanchris - Can you take a look and see if I have missed anything with regards to design/layout, etc?. Thanks.

Regression Notes

  1. Potential unintended areas of impact
    The items in the activity card are not displayed properly

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18292-09df8f2
Commit09df8f2
Direct Downloadwordpress-prototype-build-pr18292-09df8f2.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18292-09df8f2
Commit09df8f2
Direct Downloadjetpack-prototype-build-pr18292-09df8f2.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this PR since the change only update some sementic code.

@enejb
Copy link
Contributor

enejb commented Apr 20, 2023

Over all this worked really well.
I was able to see the activities.

Some things that I noticed that are a bit strange to me.

  1. In RTL mode, I would expect the icon (circle) to be on the right side of the app.
  2. When I visit the activity log. it shows me 1 less activity. I am not sure why that is. For sites that have 2 activities. I see 2 in the dashboard but only one in the activity log.
  3. I am not able to navigate to the activity. I am also not able to navigate to all activities from the dashboard.

@zwarm
Copy link
Contributor Author

zwarm commented Apr 20, 2023

Thanks @enej for testing!!!

Some things that I noticed that are a bit strange to me.

  1. In RTL mode, I would expect the icon (circle) to be on the right side of the app.

They are, it just takes a little time for the app to catch up when the language is changed on the fly. Close the app and relaunch it, you should see the icons on the right. Like this:

Alt desc

  1. When I visit the activity log. it shows me 1 less activity. I am not sure why that is. For sites that have 2 activities. I see 2 in the dashboard but only one in the activity log.

That is odd and something I haven't been experiencing in my testing. Both views are endpoint driven, but from different endpoints. I wonder if there is a difference in what type of site you are using. I've used AT, free, and business so far.

  1. I am not able to navigate to the activity. I am also not able to navigate to all activities from the dashboard.

The navigation actions are not hooked up in this PR. I'll add a note in the description above. :)

@zwarm zwarm merged commit b15858e into trunk Apr 20, 2023
@zwarm zwarm deleted the issue/activity_card_reorder_title_content branch April 20, 2023 22:20
@osullivanchris
Copy link

👋 Hey @zwarm mostly looking as expected, nice stuff. Two small details:

  • could we reduce the size of the icons to the same size as the Activity Log view. I sometimes struggle to define the right size with different screen sizes and resolution, but if you could use the value on Activity Log that should be good.
  • Could you reduce the space between items slightly. I think 4dp less would do the trick.

@zwarm
Copy link
Contributor Author

zwarm commented Apr 21, 2023

  • could we reduce the size of the icons to the same size as the Activity Log view. I sometimes struggle to define the right size with different screen sizes and resolution, but if you could use the value on Activity Log that should be good.
  • Could you reduce the space between items slightly. I think 4dp less would do the trick.

Can do @osullivanchris . I created a new issue to track it. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard Cards: Add Activity Log card in the correct position
4 participants