-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dashboard card domain to v2 #18286
Conversation
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Note: The previous version of the card supported all the accessibility features except the bold text. Maybe a good chance to introduce it. |
Updating dashboard card domain ui to match latest v2
5f40932
to
cbb6e89
Compare
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the issue in bold text. It would be nice if we could fix it now, but the issue was already opened to be fixed later. |
Set text to Bold when Bold text seting is toggled on in system settings
Fixed for this card in 904bfd3 |
👍🏻 I suppose it didn't work because I used the "Force RTL" option in the developer settings, and the translation was missing. Next time, I should test it by changing the language instead of using "Force RTL". |
Updating dashboard card domain ui to match latest v2
Fixes #18280
To test:
Additionally use the UI changes checklist
Also, do some relevant test from the UI Changes Checklist below
Regression Notes
Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested manually
What automated tests I added (or what prevented me from doing so)
Existing unit tests
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: