Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard card domain to v2 #18286

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

ravishanker
Copy link
Contributor

@ravishanker ravishanker commented Apr 19, 2023

Updating dashboard card domain ui to match latest v2

Fixes #18280

Light Dark Bold text
Screenshot_20230426_103917 Screenshot_20230426_103937 Screenshot_20230426_104020

To test:

  • Launch Jetpack/WordPress app
  • Verify domain card appears as shown above on dashboard
  • Switch to dark/night mode
  • Verify domain card matches the dark version

Additionally use the UI changes checklist

  • Tap on domain card
  • Verify that it launches domains search
  • Tap on overflow (three dots) menu
  • Verify it pops up menu with Hide this option
  • Tap on Hide this
  • Verify, the card gets hidden

Also, do some relevant test from the UI Changes Checklist below

** Note **
The browser image needs to be updated, waiting for a final version. Will update before merging

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested manually

  3. What automated tests I added (or what prevented me from doing so)
    Existing unit tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@staskus
Copy link
Contributor

staskus commented Apr 19, 2023

@ravishanker

Designer updated the assets with a static text

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 19, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18286-904bfd3
Commit904bfd3
Direct Downloadjetpack-prototype-build-pr18286-904bfd3.apk
Note: Google Login is not supported on these builds.

@staskus
Copy link
Contributor

staskus commented Apr 19, 2023

Note:

The previous version of the card supported all the accessibility features except the bold text. Maybe a good chance to introduce it.

Updating dashboard card domain ui to match latest v2
@ravishanker ravishanker force-pushed the Dashboard-card-domain-Update-card-ui-v2 branch from 5f40932 to cbb6e89 Compare April 19, 2023 08:01
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 19, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18286-904bfd3
Commit904bfd3
Direct Downloadwordpress-prototype-build-pr18286-904bfd3.apk
Note: Google Login is not supported on these builds.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻 The only issue is on the title in RTL layout. It's still aligned to the left. I'm approving, we're good to merge after fixing it.

@irfano
Copy link
Member

irfano commented Apr 24, 2023

The previous version of the card supported all the accessibility features except the bold text. Maybe a good chance to introduce it.

I noticed the issue in bold text. It would be nice if we could fix it now, but the issue was already opened to be fixed later.

Set text to Bold when Bold text seting is toggled on in system settings
@ravishanker
Copy link
Contributor Author

The previous version of the card supported all the accessibility features except the bold text. Maybe a good chance to introduce it.

Fixed for this card in 904bfd3

@ravishanker
Copy link
Contributor Author

ravishanker commented Apr 26, 2023

The only issue is on the title in RTL layout. It's still aligned to the left.

It seems to work find in LTR layout. What locale were you using? (Translations are not in place just yet)

@ravishanker ravishanker merged commit e9d4fb9 into trunk Apr 26, 2023
@ravishanker ravishanker deleted the Dashboard-card-domain-Update-card-ui-v2 branch April 26, 2023 01:17
@irfano
Copy link
Member

irfano commented Apr 26, 2023

It seems to work find in LTR layout. What locale were you using? (Translations are not in place just yet)

👍🏻 I suppose it didn't work because I used the "Force RTL" option in the developer settings, and the translation was missing. Next time, I should test it by changing the language instead of using "Force RTL".

@ravishanker ravishanker mentioned this pull request May 16, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domains Dashboard Card: Card UI v2
4 participants