Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Cards: Activity Card Foundation #18270

Merged
merged 14 commits into from
Apr 18, 2023

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Apr 13, 2023

Parent #18210

This PR adds the foundational pieces for the Activity Card dashboard item. To keep this PR small it only includes behind the scenes work, no card is displayed.

Includes

  • String and dimen resources
  • Activity card layout and card items layout
  • ActivityCard class structures (this will be further built out in later PRs)
  • View holders and adapters (this will be further built out in later PRs)
  • Updates to CardsAdapter
  • Updates to MySIteCardAndItem
  • Updates to CardsTracker and CardsShownTracker

Note: The remainder of the build out will take place in a separate PRs and will include builder and params, building out ActivityItem, tweaking the UI and displaying the card.

To test:
There is nothing to test in this PR, as this is all foundational work.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 22.3 milestone Apr 13, 2023
@zwarm zwarm requested a review from AjeshRPai April 13, 2023 15:21
@zwarm zwarm self-assigned this Apr 13, 2023
@zwarm zwarm changed the title Dashboard Cards: Activity Card Skeleton Dashboard Cards: Activity Card Foundation Apr 13, 2023
@zwarm zwarm requested review from irfano and removed request for AjeshRPai April 13, 2023 15:27
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 13, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18270-a9e40b0
Commita9e40b0
Direct Downloadwordpress-prototype-build-pr18270-a9e40b0.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 13, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18270-a9e40b0
Commita9e40b0
Direct Downloadjetpack-prototype-build-pr18270-a9e40b0.apk
Note: Google Login is not supported on these builds.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being patient with my review. 😄
Great job on the well-structured small PR!
I added some questions, concerns, and nitpicking suggestions. They are all ignorable, so I'm approving the PR but not merging it to give you the flexibility to address my comments.

@zwarm
Copy link
Contributor Author

zwarm commented Apr 18, 2023

@irfano - Thanks so much for the review. I appreciate the time you took to provide the feedback; however I won't be making any changes directly to this PR since I'm already 4 branches ahead locally. I did jot down a few of your nitpicks to address in a future PR. 🙇

@zwarm zwarm merged commit c161adc into trunk Apr 18, 2023
@zwarm zwarm deleted the issue/dashboard_cards_activity_card_skeleton branch April 18, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants