-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard Cards: Activity Card Foundation #18270
Conversation
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for being patient with my review. 😄
Great job on the well-structured small PR!
I added some questions, concerns, and nitpicking suggestions. They are all ignorable, so I'm approving the PR but not merging it to give you the flexibility to address my comments.
WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteCardAndItem.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteCardAndItem.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsTracker.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteCardAndItem.kt
Show resolved
Hide resolved
@irfano - Thanks so much for the review. I appreciate the time you took to provide the feedback; however I won't be making any changes directly to this PR since I'm already 4 branches ahead locally. I did jot down a few of your nitpicks to address in a future PR. 🙇 |
Parent #18210
This PR adds the foundational pieces for the Activity Card dashboard item. To keep this PR small it only includes behind the scenes work, no card is displayed.
Includes
CardsAdapter
MySIteCardAndItem
CardsTracker
andCardsShownTracker
Note: The remainder of the build out will take place in a separate PRs and will include builder and params, building out
ActivityItem
, tweaking the UI and displaying the card.To test:
There is nothing to test in this PR, as this is all foundational work.
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.