Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blogging Prompts] Add remote field to Social FF and enable it #18265

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

thomashorta
Copy link
Contributor

Fixes #18264

Sets a remote feature flag called blogging_prompts_social_enabled and sets the local default value of the BloggingPromptsSocialFeatureConfig flag to true.

I am using the "Not Ready for Merge" tag while I confirm if we need to add a message to the release notes.

To test:

  1. Install and open an older Jetpack app version (such as this one)
  2. Login with a WP.com account
  3. Select a blogging site (has at least a few posts)
  4. Verify the Prompts card is shown in the dashboard
  5. Verify it shows the number of answers and that is not clickable
  6. Install and open the Jetpack app from this PR
  7. Do steps 2-3 if needed
  8. Verify the Prompts card is shown in the dashboard
  9. Verify it shows a "View all responses" action
  10. Tap the "View all responses" button
  11. Verify it takes you to the topic screen for that prompt

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A just FF update.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 12, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18265-2d20793
Commit2d20793
Direct Downloadjetpack-prototype-build-pr18265-2d20793.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 12, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18265-2d20793
Commit2d20793
Direct Downloadwordpress-prototype-build-pr18265-2d20793.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @thomashorta . It's working as expected.

LGTM :shipit:

@RenanLukas RenanLukas merged commit 64c7792 into trunk Apr 12, 2023
@RenanLukas RenanLukas deleted the issue/18264-prompts-social-ff-enable branch April 12, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Blogging Prompts] Enable the social FF and update release notes
3 participants