Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move media permissions from debug to main AndroidManifest #18259

Conversation

irfano
Copy link
Member

@irfano irfano commented Apr 11, 2023

This PR moves the following permissions from /debug/AndroidManifest.xml to main/AndroidManifest.xml.

  • WRITE_EXTERNAL_STORAGE (was also already in main/AndroidManifest.xml)
  • READ_EXTERNAL_STORAGE
  • READ_MEDIA_IMAGES
  • READ_MEDIA_VIDEO
  • READ_MEDIA_AUDIO

These permissions were required for WPScreenshotTest and JPScreenshotTest, but they are also required for the main project. So, they are needed in the main AndroidManifest file.

To test:
WPScreenshotTest, JPScreenshotTest

  • WPScreenshotTestandJPScreenshotTest` should pass.

Media permissions in the app

  1. Launch the JP app on a device with API 33.
  2. Ensure you have all types of files on your media browser. (image, video, audio, and a file such as pdf)
  3. Navigate to "My Site → Media".
  4. Ensure all files on your device are listed.
  5. Tap an image.
  6. On the media detail screen, tap the save button at the top of the screen.
  7. Ensure the file is downloaded to your device.
  8. Repeat 1-7 with a device with API lower than 29.

Regression Notes

  1. Potential unintended areas of impact
    WPScreenshotTest, JPScreenshotTest and media permissions in the app.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested manually.

  3. What automated tests I added (or what prevented me from doing so)
    None because this PR doesn't introduce any change.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@irfano irfano added UI Tests Anything related to automated UI Tests. Android 13 labels Apr 11, 2023
@irfano irfano added this to the 22.2 milestone Apr 11, 2023
@irfano irfano requested a review from ravishanker April 11, 2023 23:15
@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18259-b14689a
Commitb14689a
Direct Downloadwordpress-prototype-build-pr18259-b14689a.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18259-b14689a
Commitb14689a
Direct Downloadjetpack-prototype-build-pr18259-b14689a.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

@ravishanker ravishanker merged commit 1e15f0d into Parent-PR-for-updating-targetSdkVersion-to-33-(Android-13) Apr 12, 2023
@ravishanker ravishanker deleted the move-permissions-to-main-androidmanifest branch April 12, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Tests Anything related to automated UI Tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants