Move media permissions from debug to main AndroidManifest #18259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the following permissions from
/debug/AndroidManifest.xml
tomain/AndroidManifest.xml
.WRITE_EXTERNAL_STORAGE
(was also already inmain/AndroidManifest.xml
)READ_EXTERNAL_STORAGE
READ_MEDIA_IMAGES
READ_MEDIA_VIDEO
READ_MEDIA_AUDIO
These permissions were required for
WPScreenshotTest
andJPScreenshotTest
, but they are also required for the main project. So, they are needed in the main AndroidManifest file.To test:
WPScreenshotTest
,JPScreenshotTest
and
JPScreenshotTest` should pass.Media permissions in the app
Regression Notes
Potential unintended areas of impact
WPScreenshotTest
,JPScreenshotTest
and media permissions in the app.What I did to test those areas of impact (or what existing automated tests I relied on)
Tested manually.
What automated tests I added (or what prevented me from doing so)
None because this PR doesn't introduce any change.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.