[Dependency Updates] Update squareupOkioVersion to 3.2.0
#18113
Conversation
Release Notes: https://github.com/square/okio/blob/master/CHANGELOG.md #version-320 ------------------------------------------------------------------------ Note that the latest '3.3.0' update requires Kotlin version 1.8.0. However, this project is currently compiled against Kotlin version 1.6.10. Thus, until the 'kotlinVersion' of this project gets updated to '1.8.0' updating to '3.3.0' isn't possible (see error below). ------------------------------------------------------------------------ e: java.lang.IllegalStateException: SimpleTypeImpl should not be created for error type: ErrorScope{Error scope for class <ERROR CLASS> with arguments: org.jetbrains.kotlin.types.IndexedParametersSubstitution @42489e17} ------------------------------------------------------------------------
|
Found 1 violations: The PR caused the following dependency changes: +--- project :libs:analytics
| \--- com.automattic:Automattic-Tracks-Android:2.2.0
| \--- io.sentry:sentry-android-okhttp -> 5.4.3
| \--- com.squareup.okhttp3:okhttp -> 4.9.2
-| \--- com.squareup.okio:okio:2.8.0 -> 2.10.0
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.21 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.20 -> 1.6.21
+| \--- com.squareup.okio:okio:2.8.0 -> 3.2.0
+| \--- com.squareup.okio:okio-jvm:3.2.0
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.20 -> 1.6.21
-+--- com.squareup.okio:okio:2.8.0 -> 2.10.0 (*)
++--- com.squareup.okio:okio:3.2.0 (*)
+--- com.airbnb.android:lottie:5.2.0
-| \--- com.squareup.okio:okio:1.17.4 -> 2.10.0 (*)
+| \--- com.squareup.okio:okio:1.17.4 -> 3.2.0 (*)
\--- io.coil-kt:coil-compose:1.4.0
\--- io.coil-kt:coil:1.4.0
\--- io.coil-kt:coil-base:1.4.0
- \--- com.squareup.okio:okio:2.10.0 (*)
+ \--- com.squareup.okio:okio:2.10.0 -> 3.2.0 (*)
Please review and act accordingly
|
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18113-21a2c79 | |
| Commit | 21a2c79 | |
| Direct Download | wordpress-prototype-build-pr18113-21a2c79.apk |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18113-21a2c79 | |
| Commit | 21a2c79 | |
| Direct Download | jetpack-prototype-build-pr18113-21a2c79.apk |
|
👋 @RenanLukas ! Apologies for the direct ping, but I wonder if you have the capacity for reviewing and testing this PR. Let me know, and if not, I can assign it to another engineer. I would like to avoid keeping this PR open for much longer, risking it becoming stale. |
Thomás, I randomly assigned you here and unassigned Renan. Let me know if you have the capacity to do a code review on this PR. Feel free to say no and I'll assign someone else instead. Thank you both for your help! 🙏 |
|
Hey @ParaskP7 , sorry for the late review. I've tested both WP and JP and they seem to be working as expected. There's just one thing I wanted to confirm before approving: I've changed my profile picture on JP and it didn't update on WP. I've tried closing the WP app and opening it again, but it was still showing the "old" image. Do you happen to know if this is the expected behavior? |
|
👋 @RenanLukas and many thanks for the review and testing, much appreciated! 🙇
🤞
It's been a while, let me update this branch with |
… into deps/update-square-okio-to-3.3.0
|
👋 @RenanLukas !
Ok, I verified that this is indeed what happens, when you change your profile picture on JP (or WP), it doesn't get updated on WP (or JP). But, this also occurs on Me testing this even further:
All the above means that this isn't a sync (network) issue but rather a local storage (or cache) issue on the JP (WP) app's side, which persists the old profile picture even when the user logs-out (the correct behavior would have been to update the profile picture at least on every app cold, or even hot, start). 🤷 Maybe this finding is worth opening a separate GitHub issue to deal with that at some point in the future, wdyt? 🤔 |
|
Awesome, thanks for reviewing, testing and merging this @RenanLukas , plus thanks for opening the issue, you rock! 🙇 ❤️ 🚀 |
Parent #17568
This PR updates
squareupOkioVersionto 3.2.0.Note that the latest 3.3.0 update requires Kotlin version
1.8.0. However, this project is currently compiled against Kotlin version 1.6.10.Thus, until the
kotlinVersionof this project gets updated to1.8.0updating to3.3.0isn't possible (see error below).More details
PS: @RenanLukas I added you as the main reviewer, randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.
To test:
Me Screen [GravatarApi.java & StreamingRequest.java]
My Sitetab, click on your profile's icon (top right).Mescreen you are in, click on your profile's icon (CHANGE PHOTO).Edit Photoscreen to appear.donemenu option (top right).Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.