Parent PR for updating compileSdk 33 #17947

irfano · 2023-02-12T14:25:37Z

Fixes #17790

This PR,

Creates a parent branch (feature/update-compile-sdk-33),
Disables all warnings as errors (those warnings will be resolved in separate PRs),
Resolves errors to make the PR compilable.

Next required tasks that will be merged into `feature/update-compile-sdk-33` via separate PRs:

Resolve onBackPressed warnings: Update deprecated back pressed event #18019
Resolve Intent and Bundle warnings: Update deprecated Intent and Bundle functions #18061
Resolve readParcelable warnings and add android.permission.POST_NOTIFICATIONS: Update deprecated Parcel functions #18068
Resolve PackageManager warnings: Update deprecated PackageManager functions #18077
Re-enable all warnings as errors

Warning for reviewers
This PR shouldn't be merged unless all the required tasks above are completed.

To test:

Thoroughly smoke-test both the WordPress and Jetpack apps and see if they both work as expected.

Regression Notes

Potential unintended areas of impact
As this affects a lot of classes, every screen may be impacted.

The back navigation should work as it did before, without any crashes,
Navigation between screens should work without crashing or any data loss,
Deep links,
Jetpack migration.

What I did to test those areas of impact (or what existing automated tests I relied on)
I smoke-tested notifications and screen navigations.
What automated tests I added (or what prevented me from doing so)
None. This doesn't add any new functionality to the app.

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Errors were disabled temporarily to be able to fix all errors in separate PRS. It'll be re-enabled after all errors have been fixed.

These functions were changed with Android 13.

wpmobilebot · 2023-02-12T14:42:26Z

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17947-3143cc1.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`WordPress`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`3143cc1`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2023-02-12T14:42:31Z

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17947-3143cc1.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`Jetpack`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`3143cc1`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

ParaskP7 · 2023-02-13T11:15:35Z

👋 @irfano !

FYI: I just reviewed the first 8 commits which effectively create this parent feature/update-compile-sdk-33 branch. Everything seems good to me, so it is a 👍 from my side on those.

PS: I also quickly smoke tested both, the WordPress and Jetpack apps, and the basics of functionality like posts/pages/stories, or navigating through the basic screens like my site/reader/notifications, and everything seems to be working as expected.

Activity's onBackPressed was deprecated on Android 13.

This just makes the code shorter by using an extension function.

OnBackPressedCallback was temporarily disabled to allow the system to handle the back button event.

wpmobilebot · 2023-03-15T08:04:56Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr17947-4e3568d
	Commit	`4e3568d`
	Direct Download	`wordpress-prototype-build-pr17947-4e3568d.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-03-15T08:07:00Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr17947-4e3568d
	Commit	`4e3568d`
	Direct Download	`jetpack-prototype-build-pr17947-4e3568d.apk`

Note: Google Login is not supported on these builds.

pachlava · 2023-03-16T13:31:02Z

@irfano 👋

I'm still testing, but wanted to communicate earlier something that looks like a crash, and it's not reproducible with 21.9-rc-2. It happens when I try to select a category for a new story post:

Connect to a site that supports creation of story posts
Start creating a story post
Select an image and continue
Tap Categories

az_recorder_20230316_151551.mp4

I reproduced it on Samsung A31 with Android 12 and the latest JP installable from this PR.

It's not reproducible with Pixel 7 + Android 13, and also not reproducible with JP 21.9-rc-2 on both devices.

I'll come back soon with info if it's rep on Emulator, so there might be some useful logs (I don't know how to retrieve the logs from the device after the app crash).

pachlava · 2023-03-16T13:44:14Z

I could reproduce the case above with Pixel 2 API 31 Emulator:

2023-03-16 15:43:09.128 4224-4224/com.jetpack.android.prealpha D/AndroidRuntime: Shutting down VM
    
    
    --------- beginning of crash
2023-03-16 15:43:09.133 4224-4224/com.jetpack.android.prealpha E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.jetpack.android.prealpha, PID: 4224
    java.lang.NullPointerException: null cannot be cast to non-null type org.wordpress.android.ui.posts.PrepublishingAddCategoryRequest
        at org.wordpress.android.ui.posts.PrepublishingCategoriesFragment.initViewModel(PrepublishingCategoriesFragment.kt:242)
        at org.wordpress.android.ui.posts.PrepublishingCategoriesFragment.onViewCreated(PrepublishingCategoriesFragment.kt:88)
        at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:3128)
        at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:552)
        at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:261)
        at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1899)
        at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1817)
        at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1760)
        at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:547)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7839)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

irfano · 2023-03-16T18:45:57Z

Great job, @pachlava! Good catch! It probably caused crashes in other areas too.
I fixed the crash. Can you test it on the new build?

# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/JetpackRemoteInstallActivity.kt # WordPress/src/main/java/org/wordpress/android/ui/JetpackRemoteInstallFragment.kt # WordPress/src/main/java/org/wordpress/android/ui/jpfullplugininstall/install/JetpackFullPluginInstallActivity.kt

pachlava · 2023-03-17T06:10:58Z

Hey @irfano!

Thank you for the fix 🙇 The installable from d49b8d7 does not crash 👍

I did not notice anything else, apart from two things that are not caused by this PR:

Google login is not working, but this is expected for Jalapeno Debug builds.
Back navigation is not working in several Blaze-related screen, but this is also true for 21.9-rc-2, so I'm going to communicate that separately.

Thank you!

UPD: just found out that the second point is on purpose (p5T066-3Ue-p2#comment-14484)

These files weren't removed by mistake in the last commit.

irfano · 2023-03-17T14:24:06Z

I made some changes after @pachlava's testing, which became necessary after syncing with the trunk. @ParaskP7, could you review the latest commits that were pushed after the last sub-PR was merged?

ParaskP7 · 2023-03-17T14:31:49Z

I made some changes after @pachlava's testing, which became necessary after syncing with the trunk. @ParaskP7, could you review the latest commits that were pushed after the last sub-PR was merged?

I am on-it @irfano , thanks for the ping! 👍 👀

ParaskP7 · 2023-03-17T14:37:09Z

I am on-it @irfano , thanks for the ping! 👍 👀

Done @irfano , thanks for the update, the changes look good (✅). However, I didn't test the JetpackRemoteInstallActivity related screen, maybe it is worth-it to test it (again), just to be sure that we are not missing something. Cc @pachlava

pachlava · 2023-03-20T09:55:32Z

I didn't test the JetpackRemoteInstallActivity related screen, maybe it is worth-it to test it (again), just to be sure that we are not missing something. Cc @pachlava

I didn't go for a thorough test this time, but JP plugin remote installation worked in the latest installable for me, I checked on both Android 12 and 13.

irfano · 2023-03-21T22:18:16Z

Thanks for testing @pachlava!
@ParaskP7, can we merge this now?

ParaskP7 · 2023-03-22T08:04:56Z

@ParaskP7, can we merge this now?

Yes, I believe we can @irfano , feel free to merge this when you're ready! 🚀

irfano added 7 commits February 10, 2023 17:50

Update compileSdk to 33

225b774

Disable all warnings as errors for temporary fix

69f1fb8

Errors were disabled temporarily to be able to fix all errors in separate PRS. It'll be re-enabled after all errors have been fixed.

Update changed functions of AnimatorListener

f4af1c4

These functions were changed with Android 13.

Update changed functions of MenuItem

dfddd9a

These functions were changed with Android 13.

Update changed functions of SimpleOnGestureListener

a57595c

These functions were changed with Android 13.

Remove redundant SAM-constructors

2b2b024

Move lambda argument out of parentheses in PostListActivity

41557cd

irfano added [Type] Task [Status] Not Ready for Merge Android 13 labels Feb 12, 2023

Remove unused import from MediaPickerActionModeCallback

dcec3d3

irfano self-assigned this Feb 12, 2023

ParaskP7 self-assigned this Feb 13, 2023

Merge branch 'trunk' into feature/update-compile-sdk-33

45c680b

irfano added this to the 22.1 milestone Feb 25, 2023

irfano added 6 commits February 28, 2023 00:46

Use onBackPressedDispatcher to trigger onBackPressed()

8648d0b

Activity's onBackPressed was deprecated on Android 13.

Migrate activities to OnBackPressedCallback

3bca5a7

Activity's onBackPressed was deprecated on Android 13.

Migrate dialogs to OnBackPressedCallback

bf693ec

Use extension function for OnBackPressedCallback

b1607f0

This just makes the code shorter by using an extension function.

Move lambda argument out pf parentheses

864b7db

Remove redundant null checks

0afe737

irfano mentioned this pull request Feb 28, 2023

Update deprecated back pressed event #18019

Merged

3 tasks

irfano added 5 commits March 1, 2023 18:13

Add missing super.onBackPressed() behaviors

cc9f2e9

Fix loop issue of OnBackPressedCallback in SiteCreationActivity

3a3110e

OnBackPressedCallback was temporarily disabled to allow the system to handle the back button event.

Fix the crash on JetpackFullPluginInstallOnboardingDialogFragment

1808fd4

Refactor ComponentDialog casting

1749865

Refactor onBackPressed function in CollapseFullScreenDialogFragment

fb7a69c

Re-enable all warnings as errors

77a6278

irfano added [Status] Needs Manual Testing and removed [Status] Not Ready for Merge labels Mar 15, 2023

Fix null exception on Bundle.getSerializableCompat()

d49b8d7

irfano added 3 commits March 17, 2023 14:39

Remove empty files

e4274d5

These files weren't removed by mistake in the last commit.

Update deprecated intent functions in JetpackRemoteInstallActivity

7ac2576

Update deprecated onBackPressed usage in JetpackRemoteInstallActivity

4e3568d

irfano removed the [Status] Needs Manual Testing label Mar 17, 2023

irfano added the [Status] Needs Manual Testing label Mar 17, 2023

irfano added [Status] Ready to Merge and removed [Status] Needs Manual Testing labels Mar 20, 2023

irfano requested a review from ParaskP7 March 22, 2023 12:50

ParaskP7 approved these changes Mar 22, 2023

View reviewed changes

irfano merged commit 701b8f4 into trunk Mar 22, 2023

irfano deleted the feature/update-compile-sdk-33 branch March 22, 2023 12:59

This was referenced Mar 22, 2023

Update compileSdkVersion to 33 #17842

Closed

Update deprecated functions of JetpackStaticPosterFragment #18164

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parent PR for updating compileSdk 33 #17947

Parent PR for updating compileSdk 33 #17947

irfano commented Feb 12, 2023 •

edited

Loading

wpmobilebot commented Feb 12, 2023 •

edited

Loading

wpmobilebot commented Feb 12, 2023 •

edited

Loading

ParaskP7 commented Feb 13, 2023

wpmobilebot commented Mar 15, 2023 •

edited

Loading

wpmobilebot commented Mar 15, 2023 •

edited

Loading

pachlava commented Mar 16, 2023

pachlava commented Mar 16, 2023

irfano commented Mar 16, 2023

pachlava commented Mar 17, 2023 •

edited

Loading

irfano commented Mar 17, 2023

ParaskP7 commented Mar 17, 2023

ParaskP7 commented Mar 17, 2023

pachlava commented Mar 20, 2023

irfano commented Mar 21, 2023

ParaskP7 commented Mar 22, 2023

Parent PR for updating compileSdk 33 #17947

Parent PR for updating compileSdk 33 #17947

Conversation

irfano commented Feb 12, 2023 • edited Loading

Next required tasks that will be merged into feature/update-compile-sdk-33 via separate PRs:

Regression Notes

wpmobilebot commented Feb 12, 2023 • edited Loading

wpmobilebot commented Feb 12, 2023 • edited Loading

ParaskP7 commented Feb 13, 2023

wpmobilebot commented Mar 15, 2023 • edited Loading

wpmobilebot commented Mar 15, 2023 • edited Loading

pachlava commented Mar 16, 2023

pachlava commented Mar 16, 2023

irfano commented Mar 16, 2023

pachlava commented Mar 17, 2023 • edited Loading

irfano commented Mar 17, 2023

ParaskP7 commented Mar 17, 2023

ParaskP7 commented Mar 17, 2023

pachlava commented Mar 20, 2023

irfano commented Mar 21, 2023

ParaskP7 commented Mar 22, 2023

irfano commented Feb 12, 2023 •

edited

Loading

Next required tasks that will be merged into `feature/update-compile-sdk-33` via separate PRs:

wpmobilebot commented Feb 12, 2023 •

edited

Loading

wpmobilebot commented Feb 12, 2023 •

edited

Loading

wpmobilebot commented Mar 15, 2023 •

edited

Loading

wpmobilebot commented Mar 15, 2023 •

edited

Loading

pachlava commented Mar 17, 2023 •

edited

Loading