Skip to content

Conversation

@ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Nov 17, 2022

Fixes #17467

This PR fixes the accessibility issues on the WordPress to Jetpack Migration Flow UI namely:

  • When the largest font size is set via Accessibility settings, on some devices part of the text might not be fitting on the screen.

It accomplishes this by making the content of the Notifications and Success screens scrollable.

🏁 All these changes are behind a temporary feature flag.

To test:

1️⃣ Test with largest font size

  1. Open the Jetpack app & login
  2. Go to MeApp SettingsDebug Settings
  3. Enable the JetpackMigrationFlowFeatureConfig & restart the app
  4. Toggle largest font size via accessibility settings
    a. Open the device Settings app, go to AccessibilityDisplay size and text
    b. Set Font size to the max
  5. Return to / Open the Jetpack app
  6. Tap Continue on the Welcome Step
  7. Verify that the Notifications screen can be scrolled if the text is not fitting
  8. Tap Continue on the Notifications step
  9. Verify that the Success screen can be scrolled if the text is not fitting

2️⃣ Regression Testing - with default font size

  1. Reset Accessibility font size settings
    a. Open the device Settings app, go to AccessibilityDisplay size and text
    b. Tap Reset settings at the bottom, or restore the initial font size
  2. Open the Jetpack app
  3. Tap Continue on the Welcome Step
  4. Verify that Notifications screen matches the design (no regression)
  5. Tap Continue on the Notifications step
  6. Verify that the Success screen matches the design (no regression)

Preview

Note that I've also set Display Size to max via Accessibility Settings, otherwise the text would fit on one screen on the Pixel 6 Emulator.

largeTexts_preview.mp4

Regression Notes

  1. Potential unintended areas of impact
    Migration screens behind the feature flag.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested.

  3. What automated tests I added (or what prevented me from doing so)
    N/a.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17474-f03af63.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitf03af63
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17474-f03af63.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitf03af63
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this issue @ovitrif 🙇
The code looks good and the JP app behaves as expected with large font/screen sizes (tested on Pixel 5 w/ Android 13) 🎉

@antonis antonis merged commit efee6b8 into trunk Nov 18, 2022
@antonis antonis deleted the issue/17467-fix-migration-screens-w-large-fonts branch November 18, 2022 09:36
@ovitrif ovitrif self-assigned this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Jetpack Content Migration Flow] Fix accessibility issues with large font size on migration steps

4 participants