Skip to content

Conversation

@jostnes
Copy link
Contributor

@jostnes jostnes commented Oct 11, 2022

Part of: #17281

What

This PR removes classic editor tests (e2ePublishSimplePostClassic and e2ePublishFullPostClassic) from the test suite

Why

Users are no longer able to create classic editor posts from the mobile app, so this is no longer a critical flow. There are also no recent (from this year) issues/PRs that are classic editor related confirming that this is a low-priority feature

Testing

All other tests in the test suite should still work as expected.

@jostnes jostnes added [Type] Task UI Tests Anything related to automated UI Tests. labels Oct 11, 2022
@jostnes jostnes added this to the 21.0 milestone Oct 11, 2022
@wpmobilebot
Copy link
Contributor

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17296-d7077dd.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitd7077dd
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17296-d7077dd.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitd7077dd
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@jostnes jostnes marked this pull request as ready for review October 11, 2022 09:11
@jostnes jostnes requested a review from a team as a code owner October 11, 2022 09:11
Copy link
Contributor

@pachlava pachlava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @jostnes! :shipit:

@pachlava
Copy link
Contributor

pachlava commented Oct 13, 2022

I think this can be merged @jostnes? 👋

@jostnes
Copy link
Contributor Author

jostnes commented Oct 14, 2022

I think this can be merged @jostnes? 👋

I was waiting for confirmation from the Mobile Gutenberg team on this one, got it yesterday so I'll merge this now 🚀

@jostnes jostnes merged commit 4868687 into trunk Oct 14, 2022
@jostnes jostnes deleted the uitii-remove-classic-editor-tests branch October 14, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Task UI Tests Anything related to automated UI Tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants