Skip to content

Conversation

@RenanLukas
Copy link
Contributor

Adds a feature flag to SharedLoginProvider.

To test:

1 - Install WordPress and login
2 - Set the flag isFeatureFlagEnabled to true (this cannot be done using the Debug settings screen because that is only available when the user is already logged in)
2 - Install Jetpack using the same variant (e.g. if installed WordPress version was jalapenoDebug, install Jetpack jalapenoDebug)
3 - Jetpack should NOT login automatically after launching.

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    There is no straightforward way to test the provider with our current testing tools.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17285-08f12e6.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commit08f12e6
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17285-08f12e6.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commit08f12e6
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@RenanLukas RenanLukas marked this pull request as ready for review October 7, 2022 14:02
Copy link
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @RenanLukas 🙇. LGTM 👍

@RenanLukas RenanLukas merged commit 6fb9138 into release/20.9 Oct 10, 2022
@RenanLukas RenanLukas deleted the fix/add-feature-flag-shared-login-provider branch October 10, 2022 22:52
@AliSoftware
Copy link
Contributor

This fix has now been included in the 20.9-rc-3 beta 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants