Skip to content

Conversation

@AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Oct 3, 2022

This release, we got some PRs made by external contributors from @gitstart πŸŽ‰ … but we completely forgot to tell them at the time to add entries for their changes to the RELEASE-NOTES.txt file as part of their PR. So this PR adds the relevant entries:

  • Not only to the RELEASE-NOTES.txt file (the one we expect contributors to update when they do a new PR to describe the changes, assuming those changes are interesting enough to end users to make it to the release notes)
  • But also to the WordPress/{jetpack_,}metadata/release_notes.txt files that are usually auto-generated by our release tooling when it extracts the entries from RELEASE-NOTES.txt. Since I already ran that tooling earlier today when I did the code freeze before adding those missing entries, I had to update those manually to simulate them being extracted from the RELEASE-NOTES.txt file during code-freeze.

PS: We need this PR to land ASAP so that our freelance writer can use those files (from trunk once they will have landed) to write nice editorialized copies for those entries, so we can then send that editorialized copy for release notes to translation this week.

cc @vanessamaartinstt FYI as you might want to include those additional entries in the upcoming Call for Testing you'll likely be drafting today πŸ™‚

For PRs made by external contributors from @gitstart (whom we forgot to tell at the time to add entries for their changes to the `RELEASE-NOTES.txt` file)
@AliSoftware AliSoftware added Releases Label related to managing releases Tooling labels Oct 3, 2022
@AliSoftware AliSoftware added this to the 20.9 ❄️ milestone Oct 3, 2022
@AliSoftware AliSoftware requested review from a team and hypest October 3, 2022 13:18
@AliSoftware AliSoftware self-assigned this Oct 3, 2022
@peril-wordpress-mobile
Copy link

Warnings
⚠️ The PlayStoreStrings.po file must be updated any time changes are made to release notes

Generated by 🚫 dangerJS

@AliSoftware AliSoftware enabled auto-merge October 3, 2022 13:20
@AliSoftware AliSoftware changed the title Add some missing Releaes Notes entries Add some missing Release Notes entries Oct 3, 2022
@wpmobilebot
Copy link
Contributor

JetpackπŸ“² You can test these changes on Jetpack by downloading jetpack-installable-build-pr17245-e5cd329.apk
πŸ’‘ Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commite5cd329
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

WordPressπŸ“² You can test these changes on WordPress by downloading wordpress-installable-build-pr17245-e5cd329.apk
πŸ’‘ Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commite5cd329
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

Copy link
Contributor

@spencertransier spencertransier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for explaining why the manual copying to metadata/release_notes.txt was necessary πŸ™‚

@AliSoftware AliSoftware merged commit d25d86d into trunk Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Releases Label related to managing releases Tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants