Skip to content

Conversation

@ravishanker
Copy link
Contributor

@ravishanker ravishanker commented Sep 30, 2022

Moved Threats Header out of loop to stop it from repeating with threat items

Fixes #14790

Scan Before After
Screenshot_20220930_154612 Screenshot_20220930_155400 Screenshot_20220930_160052

To test:

Setup

  • Need a Jetpack enabled site with Scan plugin installed (Follow the instructions on this P2: p1HpG7-9a5-p2) or Use the one I setup already critical-jambu.jurassic.ninja
  • You'll need to launch admin and edit plugin files and add some text and save to report threats as shown in first image above.

Test 1

  1. Login with a wp account having a scan capability and two or more threats.
  2. Go to the My Site tab -> Tap the Scan item -> Wait till the scan completes on the Scan screen.
  3. Once the threat is found, tap on the Fix All button.
  4. A Fix all threats confirmation dialog will appear.
  5. Tap OK and the threat fixing will start.
  6. Notice that the label "Threats found" repeats as many times as there are threats as shown in before image above.

Test 2

  • Build and run
  • Repeat step 1- 5 from above.
  • Notice that the label "Threats found" is shown only once as in after image above.

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    Existing threats

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Moved Threats Header out of loop to stop it from repeating with threat items
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17234-2d88947.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commit2d88947
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17234-2d88947.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commit2d88947
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining how to test the case. The problem is fixed.
LGTM! 👍🏻

@irfano irfano merged commit 66d79d1 into trunk Oct 1, 2022
@irfano irfano deleted the Fix-Threats-found-label-repeating branch October 1, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jetpack Section: Threat found label shown twice sometimes

4 participants