Media Picker: Choose From Device: Fix Video thumbnails do not load

[ashiagr]

Fixes #14618 & #15306

This PR displays thumbnails for local videos having URLs with content URI protocol, detects them as videos, and plays them on the media preview screen.

• VideoLoader did not take into consideration local videos with content URI protocol when checking for media size, and when such URLs were passed to it, it failed with MalformedURLException. To address this, file size for such files is checked according to the suggested approach in 258f726.

• Real path for local URI is passed in 983b21b so that they get detected as videos in MediaPreviewFragment via MediaUtils.isVideo otherwise they were displayed as images.

• Once detected as local videos, they're played using ExoPlayer adjustments for local videos in 46e6aeb.

To test:

1. Launch the app and go to My Site -> Post
2. Add a Video block
3. Select “Choose from device”
4. Notice that media picker is displayed and thumbnails are loaded
5. Long press a thumbnail
6. Notice that video plays properly

Regression Notes

1. Potential unintended areas of impact
   VideoLoader is used for both remote and local videos

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Tested manually that thumbnails for local as well remote videos are loaded properly and videos gets played as well

3. What automated tests I added (or what prevented me from doing so)
   None

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[peril-wordpress-mobile]

You can test the changes on this Pull Request by downloading the APKs:

• Jetpack-pr-15411-build-116324.apk
• WordPress-pr-15411-build-116324.apk

[zwarm]

@ashiagr - The code looks fine; however not all of my thumbnails load in the list. I see "Failed to load resource" glide errors.

I've attached a copy of my logcat + a video of what I am seeing in the app. I thought perhaps it was just large videos, but scrolling down and then PTR doesn't fix it.

screen-20211004-134523.mp4

logcat.txt

[ashiagr]

@zwarm, I checked it briefly. I have smaller videos on my test device so wasn't able to notice it. For one of the failing videos , I noticed length of the file was 14564617 which was greater than SIZE_LIMIT_10_MB = 10485760. So I believe it is due to large file sizes where thumbnails don't load.

While restricting previews based on video size is not an ideal solution, this PR only adds additional support for local videos with content URIs otherwise none of the local videos can be previewed in the media grid.

Regarding the Glide issue, whenever imageManager.loadThumbnailFromVideoUrl -> fallbackAction is executed, currently R.color.placeholder is directly loaded using Glide whereas it seems Glide expects a color drawable. This can be confirmed from the logs in the file you shared:

Cause (1 of 1): class java.io.FileNotFoundException: Resource does not exist: android.resource://org.wordpress.android.prealpha/color/placeholder

I wasn't able to fix it + failing test today. I'll ping you again as soon as I'm able to work on it.

Thank you so much, for testing it out! 🙏

[zwarm]

@ashiagr - Since this PR only addresses the URI issue, should we create a new issue for files over 10MB concentrating on choosing between not showing thumbnails at or or showing a message that they are too large? I don't have the answer, but would love to open it for discussion.

I'll retest when you are ready. Thanks. :)

[ashiagr]

Hey @zwarm!

I've created a new issue to find out a way to load large videos thumbnails: #15443.

Also fixed failing test (1883de3) and Glide issue (cdb0026).

This is now ready for another look. 🙏

[zwarm]

Thank you @ashiagr . All is working as expected - no more glide error. Thanks for pulling together a new issue for the thumbnail.