Skip to content

Conversation

@oguzkocer
Copy link
Contributor

This PR updates Android Gradle Plugin to 4.0.2 which matches the current FluxC version, so it can be used for composite builds. We plan to update it to the latest version as soon as we can, but that work will be more involved, so for now we are just making a minor version bump to match our versions.

To test:

  • As long as it builds and runs, we should be fine.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@oguzkocer oguzkocer added this to the 17.5 milestone May 21, 2021
@oguzkocer oguzkocer requested a review from antonis May 21, 2021 16:11
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

Messages
📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps!
WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history!

  1. cd WordPress-Android
  2. git checkout update-agp-to-4.0.2
  3. git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/WordPress-Android/14695
  4. Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/WordPress-Android/14695 and open a new PR.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this so quickly @oguzkocer! I really appreciate this 🙇

I tested this and the Android app builds and runs as expected with composite build with WordPress-FluxC-Android 🎉

Since I noticed the same issue with gutenberg-mobile/gutenberg I also created wordpress-mobile/gutenberg-mobile#3542 and WordPress/gutenberg#32144 respectively.

I tried updating WordPress-Utils-Android too but run into another issue (probably related to my java version). I also wasn't sure if this project needs to be updated too (haven't really used to till now).
A problem occurred configuring project ':WordPress-Utils-Android:WordPressUtils'.
> Could not resolve all artifacts for configuration ':WordPress-Utils-Android:WordPressUtils:classpath'.
   > Could not resolve com.automattic.android:publish-to-s3:0.2.2.
     Required by:
         project :WordPress-Utils-Android:WordPressUtils
      > Unable to find a matching variant of com.automattic.android:publish-to-s3:0.2.2:
          - Variant 'apiElements' capability com.automattic.android:publish-to-s3:0.2.2:
              - Incompatible attributes:
                  - Required org.gradle.jvm.version '8' and found incompatible value '11'.
                  - Required org.gradle.usage 'java-runtime' and found incompatible value 'java-api'.
              - Other attributes:
                  - Found org.gradle.category 'library' but wasn't required.
                  - Required org.gradle.dependency.bundling 'external' and found compatible value 'external'.
                  - Required org.gradle.libraryelements 'jar' and found compatible value 'jar'.
                  - Found org.gradle.status 'release' but wasn't required.
                  - Found org.jetbrains.kotlin.localToProject 'public' but wasn't required.
                  - Found org.jetbrains.kotlin.platform.type 'jvm' but wasn't required.
          - Variant 'runtimeElements' capability com.automattic.android:publish-to-s3:0.2.2:
              - Incompatible attribute:
                  - Required org.gradle.jvm.version '8' and found incompatible value '11'.
              - Other attributes:
                  - Found org.gradle.category 'library' but wasn't required.
                  - Required org.gradle.dependency.bundling 'external' and found compatible value 'external'.
                  - Required org.gradle.libraryelements 'jar' and found compatible value 'jar'.
                  - Found org.gradle.status 'release' but wasn't required.
                  - Required org.gradle.usage 'java-runtime' and found compatible value 'java-runtime'.
                  - Found org.jetbrains.kotlin.localToProject 'public' but wasn't required.
                  - Found org.jetbrains.kotlin.platform.type 'jvm' but wasn't required.

@oguzkocer
Copy link
Contributor Author

@antonis Unfortunately I didn't have time to work on this today. I think on gutenberg projects, there are a few more instances that needs to be updated. I'll also take care of the utils one, it looks like there is an issue with our Gradle plugin which is supposed to be updated to a new version.

Hopefully this is not blocking you, but if it's, let me know and I'll try to prioritize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants