-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update Android Gradle Plugin to 4.0.2 #14695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APK here. |
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this so quickly @oguzkocer! I really appreciate this 🙇
I tested this and the Android app builds and runs as expected with composite build with WordPress-FluxC-Android 🎉
Since I noticed the same issue with gutenberg-mobile/gutenberg I also created wordpress-mobile/gutenberg-mobile#3542 and WordPress/gutenberg#32144 respectively.
I tried updating WordPress-Utils-Android too but run into another issue (probably related to my java version). I also wasn't sure if this project needs to be updated too (haven't really used to till now).
A problem occurred configuring project ':WordPress-Utils-Android:WordPressUtils'.
> Could not resolve all artifacts for configuration ':WordPress-Utils-Android:WordPressUtils:classpath'.
> Could not resolve com.automattic.android:publish-to-s3:0.2.2.
Required by:
project :WordPress-Utils-Android:WordPressUtils
> Unable to find a matching variant of com.automattic.android:publish-to-s3:0.2.2:
- Variant 'apiElements' capability com.automattic.android:publish-to-s3:0.2.2:
- Incompatible attributes:
- Required org.gradle.jvm.version '8' and found incompatible value '11'.
- Required org.gradle.usage 'java-runtime' and found incompatible value 'java-api'.
- Other attributes:
- Found org.gradle.category 'library' but wasn't required.
- Required org.gradle.dependency.bundling 'external' and found compatible value 'external'.
- Required org.gradle.libraryelements 'jar' and found compatible value 'jar'.
- Found org.gradle.status 'release' but wasn't required.
- Found org.jetbrains.kotlin.localToProject 'public' but wasn't required.
- Found org.jetbrains.kotlin.platform.type 'jvm' but wasn't required.
- Variant 'runtimeElements' capability com.automattic.android:publish-to-s3:0.2.2:
- Incompatible attribute:
- Required org.gradle.jvm.version '8' and found incompatible value '11'.
- Other attributes:
- Found org.gradle.category 'library' but wasn't required.
- Required org.gradle.dependency.bundling 'external' and found compatible value 'external'.
- Required org.gradle.libraryelements 'jar' and found compatible value 'jar'.
- Found org.gradle.status 'release' but wasn't required.
- Required org.gradle.usage 'java-runtime' and found compatible value 'java-runtime'.
- Found org.jetbrains.kotlin.localToProject 'public' but wasn't required.
- Found org.jetbrains.kotlin.platform.type 'jvm' but wasn't required.
|
@antonis Unfortunately I didn't have time to work on this today. I think on gutenberg projects, there are a few more instances that needs to be updated. I'll also take care of the utils one, it looks like there is an issue with our Gradle plugin which is supposed to be updated to a new version. Hopefully this is not blocking you, but if it's, let me know and I'll try to prioritize it. |
This PR updates Android Gradle Plugin to
4.0.2which matches the current FluxC version, so it can be used for composite builds. We plan to update it to the latest version as soon as we can, but that work will be more involved, so for now we are just making a minor version bump to match our versions.To test:
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.