Fix v13.0 editors opt-in migration strategy problems #10332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e delay to 500ms.
…wordpress-mobile/WordPress-Android into fix/editor-opt-in-strategy * 'add/analitycs-to-GB-editor-flip' of https://github.com/wordpress-mobile/WordPress-Android: Clean up the code in `setGutenbergEnabledIfNeeded` and make easy to follow. @props @hypest
…ps://github.com/wordpress-mobile/WordPress-Android into fix/editor-opt-in-strategy-with-backend-support * 'fix/editor-opt-in-strategy-with-backend-support' of https://github.com/wordpress-mobile/WordPress-Android: Use the new API Endpoint to set the editor option on migration from v12.9 to 13.0
…rdPress-Android into fix/editor-opt-in-strategy-with-backend-support * 'release/13.0' of https://github.com/wordpress-mobile/WordPress-Android: Update the 12.9 release notes to add a note about the block editor Update release notes for 13.0 Use the tagged version of FluxC Add some additional release notes Update release notes. Bump version number Merge the bumped version number # Conflicts: # build.gradle
malinajirka
reviewed
Aug 6, 2019
Contributor
Author
|
Thanks @malinajirka for your review! I've also address in dfe29a9 the point you've raised in our chat convo, about the global (and old) app-wide editor setting being removed from the app even when the network call fails. Now it's only removed on success, and the app can re-try the migration later. |
daniloercoli
deleted the
fix/editor-opt-in-strategy-with-backend-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves and fixes the editors opt-in migration strategy by changing a couple of important things:
To test:
This still references a FluxC hash, we need to switch to a tag when the FluxC companion PR is merged and properly tagged.
Update release notes:
RELEASE-NOTES.txt.