-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Description
Master issue: #3901. While we have been working on the people management v1 #4100 we have discussed that in the current detail page it might not be obvious that the user can change the role of the user. @hypest also mentioned that you can change the role, but can't change the username and since they share the same design, it might lead to confusion. @rickybanister came up with an alternative design below:
When I initially explored this, I came up with a solution but it felt very hacky to us. It basically removes the elevation from the toolbar when you go into detail fragment and adds it back when you go back to the list.
The alternative is for us to extend the toolbar, but then comes the challenge with the behavior when you change the fragments, especially considering we'll be adding more fragments to people management as we build on it. I'll also explore if we could make the toolbar a part of the fragment instead of the activity.
This is everything that's discussed so far, I'll update the issue as I explore this more. If anyone has any insight on how to handle this, please do let me know.
/cc @nbradbury as you raised similar concerns.
