RemoteServiceException: CannotPostForegroundServiceNotificationException

[AjeshRPai]

Crash: Sentry link

android.app.RemoteServiceException$CannotPostForegroundServiceNotificationException: Bad notification for startForeground
    at android.app.ActivityThread.throwRemoteServiceException(ActivityThread.java:2222)
    at android.app.ActivityThread.-$$Nest$mthrowRemoteServiceException
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2508)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loopOnce(Looper.java:226)
    at android.os.Looper.loop(Looper.java:313)
    at android.app.ActivityThread.main(ActivityThread.java:8757)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)

[AjeshRPai]

Hey @irfano

I noticed this issue in Sentry and its happening only on Android 13. Since you were the DRI for Android 13 migration, i figured you might have more context or knowledge about this crash. Please feel free to un-assign if you feel this is not related to Android 13/ its an already known issue.

Thanks in Advance.

[irfano]

Hello, @AjeshRPai! I was AFK for the entire week when you messaged me. Unfortunately, I missed the notification when I returned. I will look into this issue this week.

[irfano]

This exception tells us we are trying to show notifications without creating a notification channel.

This issue was happening on PhaseFour, PhaseNewUsers, and PhaseSelfHostedUsers in the migration because notifications were disabled in these phases. So, we did not create notification channels, yet we were attempting to show media upload notifications even though we didn't create notification channels.

I'm closing the issue without any development because we're already in the last phase. The next step will be removing all migration settings and this issue won't occur again.

There are still some new crashes coming recently, but not many. They may have stale, cached remote flags.

To reproduce:
(We need to manipulate feature flag

1. In Android Studio, update shouldShowNotifications(). It should return false to mimic PhaseFour, PhaseNewUsers, and PhaseSelfHostedUsers.
2. Make a clean install of the WP app.
3. Log in.
4. Create a post.
5. Add a video block and a video.
6. Notice it will crash when the video is being uploaded.

Sentry link: https://a8c.sentry.io/issues/3909129591/?query=CannotPostForegroundServiceNotificationException&referrer=issue-stream&statsPeriod=90d&stream_index=0

[sentry-io]

Sentry issue: WORDPRESS-ANDROID-2H8Q

[derekblank]

There are still some new crashes coming recently, but not many. They may have stale, cached remote flags.

Hey @irfano 👋 We're still receiving Sentry event reports for this in 23.6, but it looks like they are from the same 3 - 4 users. Given the comment above, I just wanted to double check if this is expected or not, as it's currently the third-highest WPAndroid crash.

[irfano]

I have shared how I reproduced this issue previously (#18495 (comment)). However, it appears that Sentry crashes do not come from that case.
This crash always occurs after the log i/WordPress-MAIN: UploadService > Destroyed. Following the destruction of UploadService, [UploadService.startForeground()](https://github.com/wordpress-mobile/WordPress-Android/blob/trunk/WordPress/src/main/java/org/wordpress/android/ui/uploads/PostUploadNotifier.java#L138) is invoked, and leading to the crash. The underlying issue lies in the destruction of UploadService, which occurs subsequent to an upload error.

So, I believe the root cause of this crash is a media upload issue that results in the destruction of UploadService. I was unable to reproduce the issue, but I anticipate that fixing media upload issues and migrating UploadService to Workmanager will address this crash. Internal issue: https://github.com/Automattic/jetpack-mobile-roadmap/issues/1

I am reopening the issue as it's still active.

[sentry-io]

Sentry issue: WORDPRESS-ANDROID-2KJW

[antonis]

This crash always occurs after the log i/WordPress-MAIN: UploadService > Destroyed. Following the destruction of UploadService, UploadService.startForeground() is invoked, and leading to the crash. The underlying issue lies in the destruction of UploadService, which occurs subsequent to an upload error.

Based on this I believe that the UploadService fix might have covered this too #19987
I'll monitor 24.1+ to verify if this is the case or there is a regression.