Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint Warnings - Resolve AppBundleLocaleChanges #18188

Open
Tracked by #18142
ParaskP7 opened this issue Mar 28, 2023 · 1 comment
Open
Tracked by #18142

Lint Warnings - Resolve AppBundleLocaleChanges #18188

ParaskP7 opened this issue Mar 28, 2023 · 1 comment

Comments

@ParaskP7
Copy link
Contributor

ParaskP7 commented Mar 28, 2023

As part of the #18161 task, this AppBundleLocaleChanges got suppressed and moved closer to source (instead of it being within the baseline.xml file).

This was done in order to make the suppression more robust as although is seems to be working locally, it actually failing when running on CI.

However, this warning should be fixed instead and that's what this issue is about, to try and resolve this warnings instead of suppressing it (expand to see details).

Issue Details (Example)
    <issue
        id="AppBundleLocaleChanges"
        message="Found dynamic locale changes, but did not find corresponding Play Core library calls for downloading languages and splitting by language is not disabled in the `bundle` configuration"
        errorLine1="        defaultLocaleConfiguration.setLocale(defaultLocale);"
        errorLine2="        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="../libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergUtils.java"
            line="43"
            column="9"/>
    </issue>

Message: Found dynamic locale changes, but did not find corresponding Play Core library calls for downloading languages and splitting by language is not disabled in the 'bundle' configuration

PS: The above is just an example, same applies to the below:

  • GutenbergUtils.getTranslations(...)
  • ComposeUtils.LocaleAwareComposable(...)
  • LocaleManager.updatedConfigLocale(...)
  • LocaleManager.updateResources(...)
@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

ParaskP7 added a commit that referenced this issue Mar 28, 2023
This Lint warnings are being suppressed closer to source and removed
from Lint's baseline. This is done in order to make the suppression more
robust as although is seems to be working locally, it actually failing
when running on CI.

CI: https://buildkite.com/automattic/wordpress-android/builds/10254
Related: Lint Warnings - Resolve 'AppBundleLocaleChanges'
- #18188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant