Merge pull request #20836 from wordpress-mobile/issue/20535-fix-crash…

…-on-featured-image-dialog Fix a rare crash on featured image confirmation dialog
wordpress-mobile · May 18, 2024 · 1987940 · 1987940
2 parents f83cca4 + b5bd863
commit 1987940
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
@@ -4,6 +4,7 @@
 -----
 * [*] Fixed a rare crash on Posts List screen [https://github.com/wordpress-mobile/WordPress-Android/pull/20813]
 * [*] Fixed a rare crash on the Login screen [https://github.com/wordpress-mobile/WordPress-Android/pull/20821]
+* [*] Fixed a rare crash on the featured image confirmation dialog [https://github.com/wordpress-mobile/WordPress-Android/pull/20836]
 * [*] Fixed an ANR issue on the Post List screen [https://github.com/wordpress-mobile/WordPress-Android/pull/20833]
 
 24.9

diff --git a/.../editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java b/.../editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java
@@ -901,6 +901,10 @@ public void onClick(DialogInterface dialog, int id) {
 
     @UiThread
     public void showFeaturedImageConfirmationDialog(final int mediaId) {
+        if (isStateSaved()) {
+            return;
+        }
+
         GutenbergDialogFragment dialog = new GutenbergDialogFragment();
         dialog.initialize(
                 TAG_REPLACE_FEATURED_DIALOG,