Add support for Editor Settings #232
Conversation
kean
force-pushed
the
task/editor-settings
branch
from
17e0732 to
4f0d2e8
Compare
| /// let safeName = url.safeFilename | ||
| /// // Result: "https---example.com-path-query-1" | ||
| /// ``` | ||
| var safeFilename: String { |
There was a problem hiding this comment.
We could just replace it with sha256 as the folder name is only needed for technical purposes. wdyt?
There was a problem hiding this comment.
Yeah, hashing is likely sufficient for this purpose.
A readable name might make debugging easier, but that'd likely be infrequent and manageable.
There was a problem hiding this comment.
I was also leaning towards hashing. It's simpler and more robust.
kean
force-pushed
the
task/editor-settings
branch
from
4f0d2e8 to
5ef6674
Compare
|
Oh, actually, I'll call |
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Very nice!
I suppose we could consider adding a Use theme styles toggle beneath the Native Inserter toggle, if helpful.
| do { | ||
| try await service.setup(&updatedConfiguration) | ||
| } catch { | ||
| print("Failed to setup editor environment, confinuing with the default or cached configuration:", error) |
There was a problem hiding this comment.
| print("Failed to setup editor environment, confinuing with the default or cached configuration:", error) | |
| print("Failed to set up editor environment, continuing with the default or cached configuration:", error) |
| /// let safeName = url.safeFilename | ||
| /// // Result: "https---example.com-path-query-1" | ||
| /// ``` | ||
| var safeFilename: String { |
There was a problem hiding this comment.
Yeah, hashing is likely sufficient for this purpose.
A readable name might make debugging easier, but that'd likely be infrequent and manageable.
| self.authHeader = authHeader | ||
| self.urlSession = urlSession | ||
|
|
||
| self.storeURL = URL.documentsDirectory |
There was a problem hiding this comment.
This should go into "Application" not "Documents".
Good idea. It's a bit difficult due to how it's currently structured. I'll add a note to add it after other changes are done. |
Co-authored-by: David Calhoun <github@davidcalhoun.me>
What?
The demo app will now honor site's block editor settings (
wp-block-editor/v1/settings).Why?
The idea is to use the newly introduced
EditorServiceto manage the initial load and subsequent refresh of all resources required to launch the editor: editor settings and assets.In the future PRs, I plan to simplify the code in
EditorAssetsLibraryand move it toEditorService. It will fetch the manifest and the assets before "starting" the editor and will inject the preprocessed manifest using the configuration. This will give the host app control over when and how the assets are loaded and stored. With the new implementation, the requests will run in parallel, cutting the first load time by around 900ms (due to parallelization alone).I will then generate the Android implementation based on the Swift code.
How?
The new
EditorServiceprovides two simply APIs for the host app.The
setupmethod is what you call to configure the editor. On first load, it will fetch the required resources (blocking operation). On the subsequent loads, it will simply use the previously loaded data (changes infrequently). It's up to the app how to handle errors.The host app will also be responsible for calling
refreshto update the previously fetched resources (or load the initial ones). It's safe to callrefreshmultiple times as it will attach to the existing task if present. It's up to the app how to handle errors.Testing Instructions
Add a new "remote" editor and verify that the styles are applied.
Screenshots or screencast
Before / After
