Use adapter height when drawing a placeholder #998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teelair
approved these changes
Aug 2, 2022
Teelair
left a comment
Teelair
left a comment
There was a problem hiding this comment.
I tested this using Day One Android on the fix/too-big-audio-player branch.
To test, I made four entries each containing photos, audio files, videos, and a PDF. I took screenshots of the entries looked in both read and edit mode before applying this PR's changes, and then after.
The most noticeable issue where audio placeholders were visibly larger than others has been fixed, but also other placeholders have had their size slightly altered. It is not by much so I feel like this is not a big deal within the context of Day One, but because I am not sure of what all is using Aztec, I'll leave an approval and leave it up to you to merge this if that sounds okay to you @planarvoid!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This PR fixes an issue when the placeholder size was different (by a little bit) than what was defined in the adapter. This was mostly visible on smaller placeholders. I think only the last placeholder of the document was affected.
In addition it fixes the width so that the cursor doesn't overlap the placeholder
Test (it's better to test this with the PR where it's used)
EXAMPLEReview
@khaykov
Make sure strings will be translated:
strings.xmlas a part of the integration PR.