Skip to content

Move CI to Buildkite #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkmassel merged 6 commits into from
Jul 25, 2022
Merged

Move CI to Buildkite #996

jkmassel merged 6 commits into from
Jul 25, 2022

Conversation

@jkmassel
Copy link
Contributor

@jkmassel jkmassel commented Jul 23, 2022 •
edited
Loading

To Test:

  • Ensure all Buildkite CI checks pass.
  • It's ok if there are CircleCI build errors – its configuration has been removed. Once this PR is approved I'll disconnect CircleCI entirely so the error doesn't propagate to the trunk branch.

@jkmassel jkmassel requested review from ParaskP7 and oguzkocer July 23, 2022 04:51
@jkmassel jkmassel self-assigned this Jul 23, 2022
@jkmassel jkmassel force-pushed the move/everything-to-buildkite branch from 28edc9a to 524e4ce Compare July 23, 2022 05:41
@jkmassel jkmassel force-pushed the move/everything-to-buildkite branch from 524e4ce to 2dc7e6b Compare July 23, 2022 05:44
@ParaskP7 ParaskP7 self-assigned this Jul 25, 2022
ParaskP7
ParaskP7 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @jkmassel !

I have reviewed and verified correctness by checking on the Buildkite CI checks/results. Everything LGTM and it is a 👍 from my side, thank you completing this migration! 🥇 💯 🙇

@jkmassel jkmassel enabled auto-merge July 25, 2022 15:23
@jkmassel jkmassel merged commit f8b32ee into trunk Jul 25, 2022
@jkmassel jkmassel deleted the move/everything-to-buildkite branch July 25, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ParaskP7 ParaskP7 ParaskP7 approved these changes

@oguzkocer oguzkocer Awaiting requested review from oguzkocer

Assignees

@jkmassel jkmassel

@ParaskP7 ParaskP7

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkmassel @ParaskP7