Clear references in AztecExceptionHandler.kt #995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaykov
approved these changes
Jul 26, 2022
Contributor
khaykov
left a comment
khaykov
left a comment
There was a problem hiding this comment.
Smoke tested this one, and no issues so far 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
AztecExceptionHandleris leakingAztecText. In this PR I'm replacing the references withWeakReferenceso that the reference to theAztecTextis not held by the exception handler longer than necessaryReview
@khaykov
Make sure strings will be translated:
strings.xmlas a part of the integration PR.