Fix media removal and improve coroutine handling #989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
The media removal is not currently added to history. That's fixed in this PR. Also the logic to remove media span is moved to the
AztecTextso that it's reusable. I've also fixed the coroutine usage and made thePlaceholderManagera coroutine scope.Test
PlaceholderManagerin the main activity with theImageWithCaptionAdapterEXAMPLEcontain aplaceholderthat you can identifyremoveItemaction to something you can control (for example the camera button)removeItemidentify the placeholder you want to removeReview
@danilo04
Make sure strings will be translated:
strings.xmlas a part of the integration PR.