Skip to content

Conversation

@planarvoid
Copy link
Contributor

Fix

The media removal is not currently added to history. That's fixed in this PR. Also the logic to remove media span is moved to the AztecText so that it's reusable. I've also fixed the coroutine usage and made the PlaceholderManager a coroutine scope.

Test

  1. Set up PlaceholderManager in the main activity with the ImageWithCaptionAdapter
  2. Make the EXAMPLE contain a placeholder that you can identify
  3. Add removeItem action to something you can control (for example the camera button)
  4. In the removeItem identify the placeholder you want to remove
  5. Run the app
  6. Remove the placeholder
  7. Notice it gets removed correctly

Review

@danilo04

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@planarvoid planarvoid added the bug label Jun 15, 2022
@planarvoid planarvoid requested a review from danilo04 June 15, 2022 08:49
@planarvoid planarvoid self-assigned this Jun 15, 2022
Copy link
Contributor

@danilo04 danilo04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @planarvoid! Tested the changes and they are working properly :shipit: !

@danilo04 danilo04 merged commit a27546b into trunk Jun 15, 2022
@danilo04 danilo04 deleted the fix/media-removal-and-coroutines branch June 15, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants