Skip to content

Conversation

@planarvoid
Copy link
Contributor

Fix

In this PR I'm replacing the functionality when pasting text into the empty aztec editor. Currently this triggers setText which removes all the formatting spans. However, I think it's a valid use case to turn on formatting and paste text and expect the pasted text to be formatted. Otherwise the functionality remains unchanged

Test

  1. Set EXAMPLE field in the MainActivity to <h1></h1>
  2. Run the app
  3. Paste text to the editor
  4. Notice it gets formatted with h1 (previously it didn't keep the formatting)

Review

@AmandaRiu

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@planarvoid planarvoid added the bug label Jun 1, 2022
@planarvoid planarvoid requested a review from AmandaRiu June 1, 2022 11:04
@planarvoid planarvoid self-assigned this Jun 1, 2022
Copy link
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm 👍🏻

:shipit:

@AmandaRiu AmandaRiu merged commit 8be1d79 into trunk Jun 4, 2022
@AmandaRiu AmandaRiu deleted the feature/insert-pasted-text-when-text-is-empty branch June 4, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants