Enable media within paragraph blocks #984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we've added the option to
addMediaAfterBlocks. This works well with almost all the blocks but it doesn't work nicely with paragraphs. We want to be able to add images within paragraphs and not only after the currently selected paragraph. This is important for paragraphs with linebreaks (where the image should be logically positioned at the linebreak, not after the paragraph).You can test this by setting
EXAMPLEtoTest
addMediaAfterBlockson the visual editorEXAMPLEset from the code aboveReview
@danilo04
Make sure strings will be translated:
strings.xmlas a part of the integration PR.