Fix issue when adding image when no blocks are present #978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
There is an issue that when there are no blocks in the selection and the user wants to add an image. In that case the selection is set to 0 and the image is added to the beginning of the editor.
I've added unit tests to cover this functionality as well
Test
aztec.visualEditor.addMediaAfterBlocks()in theMainActivityEXAMPLEto something like<h1>Test 1</h1>\nBodyBodyBodyand not at the beginning of the editorReview
@AmandaRiu
Make sure strings will be translated:
strings.xmlas a part of the integration PR.