fix: span end should not be before the start #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantsaini1
force-pushed
the
fix/span-range
branch
from
aed843e to
379b849
Compare
Contributor
Author
|
Hi @Twinsen81, request you to please review and merge this PR as this is causing lots of crashes for some of our users. |
Twinsen81
approved these changes
Aug 1, 2025
Contributor
Twinsen81
left a comment
Twinsen81
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix!
Contributor
Author
|
@Twinsen81 Could you please get this merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
IndexOutOfBoundsException crash issue.
Test
Review
@mzorz
Make sure strings will be translated:
strings.xmlas a part of the integration PR.