Skip to content

Comments

Handle directive-heavy wp-config parsing#340

Open
mmaunder wants to merge 1 commit intomainfrom
gh-316
Open

Handle directive-heavy wp-config parsing#340
mmaunder wants to merge 1 commit intomainfrom
gh-316

Conversation

@mmaunder
Copy link
Contributor

Summary

  • add a targeted WordPress config parser that extracts DB credentials without executing helper directives
  • wire the new parser into WordpressSite and tolerate @-prefixed functions when reading wp-config
  • cover conditional defines, constant() indirection, host:port parsing, and other wp-config variants with focused unit tests

Testing

  • venv/bin/python -m unittest discover -s wordfence -t .

Copy link
Contributor

@akenion akenion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I don't think this is the best approach to solve the issue. I'll leave the PR open for now, but am not including this in the upcoming 5.0.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants