-
Notifications
You must be signed in to change notification settings - Fork 77
[지하철 노선도 미션] 이송원 미션 제출합니다. #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
swon3210
wants to merge
62
commits into
woowacourse:main
Choose a base branch
from
swon3210:swon3210
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion name this is for more clarification and consistency with other functions' way of doing work
…tead of beloinging lines
I made this change because I knew localStorage cannot store object reference value which has circular relationship with other object. now, arrays which contained all stations and lines now converted as object using their names as its key
if I use terminating stations or terminiating station names for getting all station names in the line, the methods get pretty complicated and inefficient. so I changed subway line class to have its own station name list. we can use the station name for referencing subway station object
- remove exception#7 since it is no longer an exception
…s needs index parameter too
…lass for more security
…bway line' with alert message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
그동안 수고 많으셨습니다!
처음엔 연결리스트로 중심 로직을 구현하려고 했는데 로컬 스토리지가 순환 참조를 허용하지 않는다는 것을 알게 된 후로는 방향을 틀어서 개발하게 되었습니다. 로컬 스토리지와 같은 브라우저 내장 기능에 대한 이해가 많이 필요하다는 것을 느끼게 된 시간이었습니다.