[JDBC 라이브러리 구현하기 - 1단계] 페드로(류형욱) 미션 제출합니다. #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsulocalize
requested changes
Oct 3, 2024
Comment on lines
38
to
51
| public <T> List<T> query(String sql, Function<ResultSet, T> rowMapper, Object... args) { | ||
| List<T> results = new ArrayList<>(); | ||
| try (PreparedStatement ps = dataSource.getConnection().prepareStatement(sql)) { | ||
| setParameters(ps, args); | ||
| try (ResultSet rs = ps.executeQuery()) { | ||
| while (rs.next()) { | ||
| results.add(rowMapper.apply(rs)); | ||
| } | ||
| } | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException("Query 실패", e); | ||
| } | ||
| return results; | ||
| } |
| import org.junit.jupiter.api.DisplayName; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.Mockito; | ||
|
|
||
| class JdbcTemplateTest { |
There was a problem hiding this comment.
쿼리 실패, 매핑 실패 케이스에 대한 테스트도 추가되면 좋을 것 같아요!
There was a problem hiding this comment.
쿼리 실패와 매핑 실패를 따로 테스트하기에는 모킹한 것을 그대로 테스트하는 모습이 될 것 같았어요. 초점을 두고 검증해야 할 부분은 Checked Exception을 Unchecked Exception으로 래핑하는 부분이라고 생각해서 해당 부분에 대한 테스트를 추가했습니다!
tsulocalize
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 우주 🚀
지난 미션에서는 제가 리뷰어였는데 이번에는 반대로 만나게 됐네요ㅋㅋㅋ
1단계는 요구사항이 많지 않아 간단히 구현해 봤어요.
리뷰 잘 부탁드립니다!