[2단계 - 블랙잭(베팅)] 레넌(조형래) 미션 제출합니다.#340
Merged
workromancer merged 15 commits intowoowacourse:broraefrom Mar 20, 2022
Merged
Conversation
workromancer
suggested changes
Mar 18, 2022
workromancer
left a comment
workromancer
left a comment
There was a problem hiding this comment.
안녕하세요 레넌~
step2 를 진행하시면서 기존 코드에 많은 변경 없이 잘 구현해주셨는데요.
새로 추가해주신 부분에 코멘트 몇 개 남겨두었으니 확인 부탁드려요.
확인 후 다시 PR 주세요 ㅎㅎ
Author
|
Map키를 User로 모두 통일을 시켜주었는데요, 그러다 보니 View에서 출력을 할 때 순서가 보장되지가 않았습니다. 그래서 View에서 정렬을 시켜준뒤 출력을 해주었습니다. 그리고 CardDeckGenerator를 인터페이스로 만들어 테스트에 용이하도록 했습니다. 오늘 상태 패턴으로 블랙잭을 만드는 강의를 들었는데, 제 코드가 많이 지저분해 보이네요 :( |
workromancer
approved these changes
Mar 20, 2022
workromancer
left a comment
workromancer
left a comment
There was a problem hiding this comment.
안녕하세요 레넌~
이미 step1 하면서 잘 구현해주셔서 이번에는 크게 코멘트 남길 부분이 없네요 ㅎㅎ
step2 에서도 전반적으로 잘 구현해주셨어요.
코멘트 몇 개 남겨둔 것이 있는데 확인 부탁드려요 ㅎㅎ
블랙잭 미션은 이만 머지해도 괜찮을 것 같습니다 !
고생하셨습니다 !
brorae
added a commit
to brorae/java-blackjack
that referenced
this pull request
Mar 20, 2022
This reverts commit 422d83e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안녕하세요, 루피!
2단계도 잘 부탁드리겠습니다!