[1단계 - 블랙잭] 레넌(조형래) 미션 제출합니다.#264
Merged
workromancer merged 42 commits intowoowacourse:broraefrom Mar 17, 2022
Merged
Conversation
workromancer
suggested changes
Mar 12, 2022
workromancer
left a comment
workromancer
left a comment
There was a problem hiding this comment.
레넌 안녕하세요. 루피입니다.
전반적으로 잘 구현해주셨는데요.
몇 가지 코멘트 남겨두었으니 확인 부탁드려요.
남겨주신 질문들은 이번 미션 마지막까지 구현하시면서 고민해보시고 적절한 방법이 있으면 저도 한번 알려주세요 ㅎㅎ
kang-hyungu
requested changes
Mar 16, 2022
kang-hyungu
left a comment
kang-hyungu
left a comment
There was a problem hiding this comment.
레넌 몇 가지 코멘트 남겼습니다.
수정해보시고 리뷰 재요청주세요.
soominsohn
added a commit
to soominsohn/java-blackjack
that referenced
this pull request
Mar 16, 2022
* feat(study): add junit test case study * feat(calculator): add TDD string calculator and test * docs(README.md): add function implement list * feat(game input): add get car name input * feat(validate): add car name input validate * feat(validate): add car coin input validate * feat(car): add move car position function * feat(car): add print car position result * feat(result): add print game winners * refactor(magicNumber): change magic number to constant * refactor: divide functions to reduce indent * style: adopt google convention * refactor(Input): change field initialize stategy * refactor(constant): move constants to each class * refactor(pattern): change pattern to static final * feat(winner): change findWinnerByPosition stream method * feat(arrangement): rearrange public and private method * refactor(car): change random number generate logic for test * test(car): add unit test for Car class * refactor(car): relocate car name validate logic * test(car): add car name test * test(input): add input test * test(inputValidator): add inputValidator test * style: delete unused packages * refactor(game): change field initialize locate Co-authored-by: soominsohn <soominsohn@gmail.com>
workromancer
approved these changes
Mar 16, 2022
workromancer
left a comment
workromancer
left a comment
There was a problem hiding this comment.
안녕하세요 레넌~
피드백 반영해주신 내용 잘 확인하였습니다.
전반적으로 객체들 간의 역할이 적절히 잘 나뉘어진 것 같다고 느껴집니다.
간단한 코멘트 남겨두었으니 확인해주세요.
step1 고생 많으셨습니다~ step2 에서 뵈어요 !
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안녕하세요, 루피!
이번 미션 잘 부탁드립니다!
질문사항
일급컬렉션에 값을 추가하고, 추가가 제대로 되었는지 확인하는 테스트는 어떤 방식으로 하는게 좋을까요?? 값이 제대로 들어갔는지 확인하려면 test를 위한 getter를 만들게 되거나, size()로 테스트를 하게 되더라구요.
상수의 사용을 private static final로 사용해왔는데, 여러 클래스에서 같은 의미로 사용된다면 public static final로 사용해도 상관이 없을까요??
상속 클래스에서 접근제한자를 protected로 두고 사용하는 방식이 좋은 방법인지 궁금합니다!
감사합니다.