Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: If a name is defined, should be used the defined name #564

Merged
merged 10 commits into from
Jun 4, 2024

Conversation

jiho-kr
Copy link
Contributor

@jiho-kr jiho-kr commented Jun 4, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #558

What is the new behavior?

The generic name is also being used by classes whose names are defined as side effects of #546

If a name is defined, should be used the defined name

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jiho-kr jiho-kr added the bug Something isn't working label Jun 4, 2024
@jiho-kr jiho-kr requested a review from Pigrabbit June 4, 2024 04:42
@jiho-kr jiho-kr self-assigned this Jun 4, 2024
@jiho-kr jiho-kr merged commit d06ceb5 into woowabros:main Jun 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant