refactor: improve validation for search route and refactor test code (#…

…548)
woowabros · May 26, 2024 · 19db835 · 19db835
1 parent a103a02
commit 19db835
Show file tree

Hide file tree

Showing 4 changed files with 392 additions and 327 deletions.
diff --git a/src/lib/crud.service.ts b/src/lib/crud.service.ts
@@ -31,29 +31,23 @@ export class CrudService<T extends EntityType> {
 
     readonly reservedReadMany = async (crudReadManyRequest: CrudReadManyRequest<T>): Promise<PaginationResponse<T>> => {
         crudReadManyRequest.excludedColumns(this.columnNames);
-        try {
-            const { entities, total } = await (async () => {
-                const findEntities = this.repository.find({ ...crudReadManyRequest.findOptions });
+        const { entities, total } = await (async () => {
+            const findEntities = this.repository.find({ ...crudReadManyRequest.findOptions });
 
-                if (crudReadManyRequest.pagination.isNext) {
-                    const entities = await findEntities;
-                    return { entities, total: crudReadManyRequest.pagination.nextTotal() };
-                }
-                const [entities, total] = await Promise.all([
-                    findEntities,
-                    this.repository.count({
-                        where: crudReadManyRequest.findOptions.where,
-                        withDeleted: crudReadManyRequest.findOptions.withDeleted,
-                    }),
-                ]);
-                return { entities, total };
-            })();
-            return crudReadManyRequest.toResponse(entities, total);
-        } catch (error) {
-            Logger.error(JSON.stringify(crudReadManyRequest));
-            Logger.error(error);
-            throw error;
-        }
+            if (crudReadManyRequest.pagination.isNext) {
+                const entities = await findEntities;
+                return { entities, total: crudReadManyRequest.pagination.nextTotal() };
+            }
+            const [entities, total] = await Promise.all([
+                findEntities,
+                this.repository.count({
+                    where: crudReadManyRequest.findOptions.where,
+                    withDeleted: crudReadManyRequest.findOptions.withDeleted,
+                }),
+            ]);
+            return { entities, total };
+        })();
+        return crudReadManyRequest.toResponse(entities, total);
     };
 
     readonly reservedReadOne = async (crudReadOneRequest: CrudReadOneRequest<T>): Promise<T> => {